Repository navigation
fix(build): order the docs-site build after every package build - #47
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2e9e8c6fab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "outputs": [ | ||
| "build/**", | ||
| ".docusaurus/**" | ||
| ] |
There was a problem hiding this comment.
On a clean checkout where this task is a cache hit, Turborepo restores only the declared outputs, but the prebuild also emits the ignored docs/api/npm/**, docs/api/index.mdx, docs/packages/*.mdx, and api-sidebar.generated.json files. Because none of those paths is listed here, the same successful build leaves these artifacts present on a cache miss and absent on a hit, so subsequent source-level documentation checks or consumers observe nondeterministic state. Include all generated paths in this task's outputs.
AGENTS.md reference: AGENTS.md:L355-L359
Useful? React with 👍 / 👎.
184ae7c to
50369f5
Compare
site/package.json declares no workspace package as a dependency, so turbo's `^build` gave the docs site no ordering against the packages whose built `dist` its prebuild (scripts/generate-api-reference.mjs) resolves through node_modules. On a fresh clone the prebuild raced the package builds and failed with "new undocumented stable export: createGraphStore / graphStore (prometheus-entity-management)"; a warm turbo cache hid it locally. Reproduced deterministically with `rm -rf packages/*/dist && turbo run build --force` (prebuild started before entity-graph-core's tsup), then fixed by giving `@prometheus-ags/entity-graph-docs-site#build` an explicit dependsOn on all 13 package builds. The same forced build now runs the prebuild after the packages and passes (22/22 tasks). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
50369f5 to
ed9b0f0
Compare
1 participant
Summary
pnpm run ci:buildfails intermittently on a fresh clone with:site/package.jsondeclares none of the workspace packages as dependencies, so turbo's^buildgives the docs site no ordering against them. Itsprebuild(scripts/generate-api-reference.mjs) runs TypeDoc, which resolves@prometheus-ags/entity-graph-coreetc. throughnode_modulesto their builtdist/*.d.ts. When the prebuild starts before those packages have built, the re-exported symbols lose their doc comments and the policy check fails. A warm turbo cache hides it locally, which is why it went unnoticed; CI never reached this step because the Cargo fetch failed first (#45).Fix:
turbo.jsongives@prometheus-ags/entity-graph-docs-site#buildan explicitdependsOnon all 13 package builds. No lockfile or dependency changes.Test plan
rm -rf packages/*/dist && pnpm exec turbo run build --forceonmainreproduces the failure deterministically (prebuild at log line 11,entity-graph-coretsup at line 19).generate-api-reference PASS; 22/22 tasks.Build all workspacesstep green once fix(ci): regenerate the Tauri fixture Cargo.lock (MSRV-aware) #45 lets CI reach it.🤖 Generated with Claude Code