Skip to content

fix: restore workspace clippy and worker unit-test build - #37

Merged
GQAdonis merged 1 commit into
mainfrom
fix/workspace-gate-regressions
Oct 4, 2026
Merged

GQAdonis merged 1 commit into
mainfrom
fix/workspace-gate-regressions

Conversation

@GQAdonis

@GQAdonis GQAdonis commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes two regressions on main (v1.10.0, 1126c30):

  1. Workspace clippy (from feat(ingest,context): --type and --tag on ingest, --tag filter on context #34). Adding required_tags gave pk-cli's run_context 8 parameters, which tripped clippy::too_many_arguments under -D warnings. The options are now bundled into a borrowed ContextRequest { query, scopes, limit, max_candidates, max_bytes, format, tags } struct. No allow attribute is used. pk context is a frozen surface, so its CLI flags, behaviour and output are unchanged; only the internal call shape changed.
  2. Worker unit-test build (from fix(worker): attribute learning to project/team/role and commit the prompt snapshot #32). The learning_job test helper in pk-learning-worker/src/main.rs built a LearningJob without the new project_id, team_id and role_id fields, so the module-local tests no longer compiled. The helper now sets those fields to None.

Local gate (run serially on the development machine)

  • cargo clippy --locked --workspace --all-targets -- -D warnings gave Finished dev profile [unoptimized + debuginfo] target(s) in 47.62s (exit 0, no warnings)
  • cargo test --locked -p pk-learning-worker --bins gave test result: ok. 19 passed; 0 failed
  • cargo test --locked -p pk-cli --test context --test context_scoring --test tags_and_type
    • context: ok. 3 passed; 0 failed
    • context_scoring: ok. 3 passed; 0 failed
    • tags_and_type: ok. 1 passed; 0 failed
  • cargo test --locked -p pk-learning-worker --test attribution --test worker
    • attribution: ok. 2 passed; 0 failed
    • worker: ok. 5 passed; 0 failed
  • rustfmt --check on both changed files is clean.

This PR adds no dependencies and changes no version, versions.toml or .prometheus/ files.

🤖 Generated with Claude Code

- pk-cli: bundle `pk context` options into a borrowed ContextRequest so
  run_context no longer trips clippy::too_many_arguments (regression from
  #34 adding required_tags). CLI flags, behaviour and output are unchanged.
- pk-learning-worker: the learning_job test helper now sets the
  project_id, team_id and role_id fields added in #32 to None, so the
  module-local unit tests compile again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@GQAdonis
GQAdonis merged commit 22aacbb into main Oct 4, 2026
1 of 3 checks passed
@GQAdonis
GQAdonis deleted the fix/workspace-gate-regressions branch October 11, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant