Repository navigation
fix: restore workspace clippy and worker unit-test build - #37
Merged
Merged
Conversation
- pk-cli: bundle `pk context` options into a borrowed ContextRequest so run_context no longer trips clippy::too_many_arguments (regression from #34 adding required_tags). CLI flags, behaviour and output are unchanged. - pk-learning-worker: the learning_job test helper now sets the project_id, team_id and role_id fields added in #32 to None, so the module-local unit tests compile again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two regressions on
main(v1.10.0, 1126c30):required_tagsgavepk-cli'srun_context8 parameters, which trippedclippy::too_many_argumentsunder-D warnings. The options are now bundled into a borrowedContextRequest { query, scopes, limit, max_candidates, max_bytes, format, tags }struct. No allow attribute is used.pk contextis a frozen surface, so its CLI flags, behaviour and output are unchanged; only the internal call shape changed.learning_jobtest helper inpk-learning-worker/src/main.rsbuilt aLearningJobwithout the newproject_id,team_idandrole_idfields, so the module-local tests no longer compiled. The helper now sets those fields toNone.Local gate (run serially on the development machine)
cargo clippy --locked --workspace --all-targets -- -D warningsgaveFinished dev profile [unoptimized + debuginfo] target(s) in 47.62s(exit 0, no warnings)cargo test --locked -p pk-learning-worker --binsgavetest result: ok. 19 passed; 0 failedcargo test --locked -p pk-cli --test context --test context_scoring --test tags_and_typeok. 3 passed; 0 failedok. 3 passed; 0 failedok. 1 passed; 0 failedcargo test --locked -p pk-learning-worker --test attribution --test workerok. 2 passed; 0 failedok. 5 passed; 0 failedrustfmt --checkon both changed files is clean.This PR adds no dependencies and changes no version,
versions.tomlor.prometheus/files.🤖 Generated with Claude Code