chore(deps): refresh memory, liter-llm, and knowledge pins - #73
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2db13612f1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| else | ||
| fail "/usr/local/bin is not writable; MLX deployment requires both installed copies" | ||
| exit 1 |
There was a problem hiding this comment.
On a normal unprivileged Apple Silicon installation where /usr/local/bin is root-owned, this branch exits after successfully installing the executor and resource bundle under ~/.local/bin. The service renderer already searches that user-local directory, and the adjacent surreal-memory-server installation treats the system copy as optional, so requiring both copies aborts the entire binary installation unnecessarily; only require replacement of /usr/local/bin when an existing copy would shadow the user-local executable.
Useful? React with 👍 / 👎.
| [ -f "$surreal_memory_bin" ] || surreal_memory_bin="$BIN_FALLBACK_DIR/surreal-memory-server" | ||
| surreal_mlx_executor="$(resolve_bin surreal-memory-mlx-executor)" | ||
| [ -n "$surreal_mlx_executor" ] || surreal_mlx_executor="$BIN_FALLBACK_DIR/surreal-memory-mlx-executor" | ||
| local local_embedding_backend="${PROMETHEUS_LOCAL_EMBEDDING_BACKEND:-mlx}" |
There was a problem hiding this comment.
On supported Intel macOS hosts, the MLX build section in scripts/install-binaries.sh is skipped because it is restricted to Darwin-arm64, but this canonical service renderer still defaults LOCAL_EMBEDDING_BACKEND to mlx and supplies a nonexistent fallback executor path. The resulting surreal-memory LaunchAgent cannot initialize its embedding backend and fails its health check; select mlx only when a usable executor was resolved, otherwise default to candle or reject the unsupported architecture before rendering.
Useful? React with 👍 / 👎.
1 participant
Summary
Dependency
Merge Prometheus-AGS/surreal-memory-server#12 before this PR so the referenced submodule commit is available from main.
Local validation
Commit 2db1361 is SSH-signed.