fix(operations): bound direct database waits - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The durable operation coordinator called the SurrealDB client directly, so a database future could remain pending outside the storage operation deadline while health endpoints stayed green. This applies the configured query timeout to every direct ledger database future and reports the failed stage, while leaving embedding executor work under its existing watchdog.
Validation:
openspec validate bound-operation-query-deadlines --strictRUSTC_WRAPPER= cargo check --locked --package surreal-memory-server --no-default-features --features server-onlyRUSTC_WRAPPER= cargo test --locked --test operation_query_deadline --no-default-features --features server-only(1 passed)RUSTC_WRAPPER= cargo test --locked --test executor_recovery(4 passed)Review: isolated critic round 1 found the recovery assertion used a second coordinator; fixed. Round 2 found a fixture race; fixed by seeding the terminal receipt before starting the coordinator. The two-round review cap prevented a third review, and the repaired server-mode regression passed.