fix: isolate operation ledger recovery - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installed service could time out a ledger query on the same WebSocket used by ordinary storage, then broadly retry executor failures while trying to recover. This change opens a separate server-mode ledger transport before the first query, preserves the embedded in-process path, serializes generation replacement, and limits retries to a typed recovered stale-ledger deadline.
The focused regressions exercise concurrent initialization, overlapping replacement, replacement failure, startup retry, the actual coordinator drain branch, executor-error exclusion, and ordinary storage responsiveness during four real server-mode query cancellations.
Validation:
cargo fmt --all --checkgit diff --checkcargo check --locked --package surreal-memory-server --no-default-features --features server-onlycargo test --locked --lib operations::tests:: -- --nocapture— 17 passedcargo test --locked --test operation_query_deadline --no-default-features --features server-only -- --nocapture— 1 passedcargo test --locked --test executor_recovery -- --nocapture— 4 passedThe dependency audit still reports the same three advisories present in the committed baseline lockfile;
cargo-denyis not installed. Deployment and backlog-drain certification remain a separate task after merge.