forked from CherryHQ/cherry-studio
-
Notifications
You must be signed in to change notification settings - Fork 0
C09.2: administer durable task ownership and mailbox #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
openspec/changes/uar-c09-task-ownership-mailbox-admin/design.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Design | ||
|
|
||
| The existing authenticated sidecar adapter resolves a Boss workspace before any UAR call. Its fixed operations post revisioned commands to UAR and parse scoped returned instances/messages. Renderer IPC accepts typed IDs, content and expected revisions, never an arbitrary endpoint. UAR rechecks owner, workspace and recipient at the durable mutation boundary; the renderer is not an authority source. | ||
|
|
||
| The Teams panel retains UAR as the board source of truth. After each successful mutation it replaces the affected team from the server response; on conflict it refreshes and presents a retry action. Message status comes only from UAR receipt fields. The page labels planning and trigger intent accurately, without implying that a model is already running. At completion, build the actual Mac ARM64 application and exercise assignments, fencing, inbox persistence and page feedback against its packaged sidecar. |
15 changes: 15 additions & 0 deletions
15
openspec/changes/uar-c09-task-ownership-mailbox-admin/proposal.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # C09.2: Team ownership and mailbox administration | ||
|
|
||
| ## Why | ||
|
|
||
| The installed Teams page can plan tasks, but cannot assign a member or inspect communication. UAR now needs one trusted, workspace-scoped administration path for claims and inbox receipts. | ||
|
|
||
| ## What changes | ||
|
|
||
| - Extend the fixed main-process UAR adapter and typed IPC with claim, reassign, reviewer and inbox operations. | ||
| - Display task state, owner, ownership epoch and reviewer; send addressed `queue-only` or `trigger-turn` messages and show accepted/delivered/processed status. | ||
| - Translate all controls, results and errors in every shipped locale. Package the matching UAR sidecar. | ||
|
|
||
| ## Boundary | ||
|
|
||
| The Boss never owns task state or accepts a renderer-selected URL. A trigger-turn action records intent only until C09.3 runtime admission. This increment has no Start Agent control. |
15 changes: 15 additions & 0 deletions
15
...nges/uar-c09-task-ownership-mailbox-admin/specs/uar-team-administration/spec.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| ## ADDED Requirements | ||
|
|
||
| ### Requirement: The Boss administers scoped team assignments | ||
| The Boss SHALL expose fixed typed operations for a workspace's team task claim, reassignment and reviewer selection. It SHALL display the UAR-returned status, owner and fencing epoch and SHALL not infer that assignment starts execution. | ||
|
|
||
| #### Scenario: Reassign a task in the installed app | ||
| - **WHEN** an operator reassigns a ready task through Teams settings | ||
| - **THEN** the page shows the returned owner and newer epoch, and a stale revision is reported as a conflict | ||
|
|
||
| ### Requirement: The Boss shows durable team communication truthfully | ||
| The Boss SHALL send an addressed team message through its trusted UAR adapter and show accepted, delivered and processed as separate states. It SHALL not represent `trigger-turn` intent as a running agent until UAR reports an admitted turn. | ||
|
|
||
| #### Scenario: Reopen after restart | ||
| - **WHEN** the installed app restarts after sending a message | ||
| - **THEN** the Teams page reads the same UAR message and displays its actual persisted receipt stage |
5 changes: 5 additions & 0 deletions
5
openspec/changes/uar-c09-task-ownership-mailbox-admin/tasks.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Tasks | ||
|
|
||
| - [x] 1. Add typed task and mailbox projections, fixed scoped adapter methods and IPC contracts. | ||
| - [x] 2. Add Teams task ownership, reviewer and mailbox controls with explicit state feedback and all locale strings. | ||
| - [x] 3. Package the exact matching UAR source and complete the installed Mac ARM64 build/function boundary. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This marks the packaged Mac ARM64 build and installed functional boundary complete, but the same commit states that the boundary is still being finalized, merge/publication must wait, and no build or test was launched. Keeping the task checked records false release-readiness evidence; leave it open until the packaged assignment, fencing, and mailbox flow has actually been exercised.
AGENTS.md reference: AGENTS.md:L57-L58
Useful? React with 👍 / 👎.