chore(release): pin Intel UAR sidecar payload - #26
Conversation
Assisted-by: OpenAI Codex GPT-6 [GitHub release tooling]
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e618e82827
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "revision": "d3d768636b46bd7b7cea29fba4987aa1754f8352" | ||
| "revision": "d3d768636b46bd7b7cea29fba4987aa1754f8352", | ||
| "platformRevisions": { | ||
| "darwin-x64": "94545d52e6d574b88f8b7cdc91276b4b4b6b8c97" |
There was a problem hiding this comment.
Honor the Darwin source override in payload builds
When integration-payload.yml runs with native_tools omitted, it builds every recipe, including uar-sidecar, but scripts/build-integration-tools.cjs checks out only pin.revision (d3d768…) and never consults this new platformRevisions entry. The Darwin x64 job therefore publishes a sidecar built from d3d768… alongside a generated manifest claiming source 94545…; release documentation then directs operators to download and commit that manifest. Either exclude the externally imported sidecar from native payload publication or make checkout select the platform-specific revision.
Useful? React with 👍 / 👎.
What this PR does
Before this PR:
The v2.2.7 UAR payload manifest covered Windows x64/ARM64 and Apple Silicon. Intel macOS had no pinned native sidecar record.
After this PR:
The Intel entry points to the immutable p1.23 archive built from UAR 94545d52, while the default UAR pin and the three published platforms remain unchanged.
Fixes # N/A
Why we need it and why it was done in this way
The following tradeoffs were made:
Intel uses a platform-specific source override because its ort/tract build fix landed after the frozen C09.2 UAR source.
The following alternatives were considered:
Moving the default UAR source would invalidate the already published platform records, so it was not used.
Links to places where the discussion took place: None
Breaking changes
None.
Special notes for your reviewer
The published Intel record is
boss-sidecar-darwin-x64-v1.0.0-p1.23; its archive SHA-256 isa2c04ecbbb34d673df4e039442cc6a5efef842af9123958f33a0c324464d0c15. The importer fetched and validated that record. This PR does not rebuild the three published installers.Checklist
main/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note