feat: package UI routing and adopt the existing Boss team - #4
Conversation
Pin the portable mini pack, synchronize built-in skills and preserve direct Node helper execution. Bind the existing team to shared routing while retaining native permissions, ownership and full-pack anti-shadowing behavior. Preserve generated artifact hashes through formatting hooks. Assisted-by: Codex:GPT-6 [Node.js, Git, research tools]
Preserve current release and liter-llm catalog packaging, update both integration manifests to the reviewed mini branch, and resynchronize built-in skills. Packaged UI/team gate and skill drift checks pass. Assisted-by: Codex:GPT-6 [Node.js, Git]
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Assisted-by: Codex:GPT-6 [Node.js, Git]
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37820f4ab1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,151 @@ | |||
| --- | |||
| name: agent-team-creator | |||
There was a problem hiding this comment.
This commit adds nine tracked .agents/skills/* trees without adding their names to .agents/skills/public-skills.txt or regenerating the corresponding gitignores and .claude/skills symlinks. Because scripts/skills-check.ts rejects every tracked skill outside that whitelist and CI runs pnpm skills:check, the repository's basic CI check deterministically fails; add the intended shared skills to the whitelist and run pnpm skills:sync.
Useful? React with 👍 / 👎.
| @@ -42,7 +42,7 @@ Completed kbd-new-child — <parent>/<child> ready for /kbd-assess | |||
| ## How to invoke | |||
|
|
|||
| ```bash | |||
| boss-mini kbd-new-child.mjs <child-name> [goal-1] [goal-2] … | |||
| node scripts/kbd-new-child.mjs <child-name> [goal-1] [goal-2] … | |||
There was a problem hiding this comment.
In development or another unpackaged built-in installation, this instruction now runs node scripts/kbd-new-child.mjs, although this skill contains only SKILL.md and no scripts/ directory. installBuiltinSkills() copies resources/skills verbatim, while the rewrite back to boss-mini occurs only in release packaging and separate home/project push flows, so activating this built-in directs the agent to a nonexistent workspace-relative script; retain boss-mini here or ship and resolve the helper at this installation boundary.
AGENTS.md reference: AGENTS.md:L239-L243
Useful? React with 👍 / 👎.
| const nativeFiles = installed.files.filter(file => file.sha256 && file.path.includes('/agents/')); | ||
| for (const file of nativeFiles) assert.equal(digest(path.join(boss, file.path)), file.sha256, file.path); | ||
| const reconciliation = JSON.parse(fs.readFileSync(path.join(boss, '.agent-team/boss-core/reconciliation.json'), 'utf8')); | ||
| const prior = JSON.parse(fs.readFileSync(path.join(reconciliation.sourceCheckout, '.agent-team/boss-core/team.json'), 'utf8')); |
There was a problem hiding this comment.
When this packaged validation gate runs from any checkout other than the author's machine, reconciliation.sourceCheckout is the committed absolute path /Users/gqadonis/Projects/prometheus/the-boss, so this synchronous read raises ENOENT, marks the case failed, and makes the gate exit nonzero. Use repository-relative committed evidence or stored hashes instead of dereferencing a developer-local checkout.
AGENTS.md reference: AGENTS.md:L239-L243
Useful? React with 👍 / 👎.
1 participant
What this PR does
Before this PR:
The shared UI catalog and project-team adoption were not included in The Boss packaged mini payload.
After this PR:
The Boss bundles the shared UI/UX router, portable design catalog and Node helpers, and adopts its existing boss-core team for code work.
Why we need it and why it was done in this way
The shared protocol and portable runtime come from the mini repository. The existing team remains the authority for role ownership and native configuration. No new daemon, shell hook or runtime download is introduced for the UI helpers.
Validation and remaining gaps
After merging current main: the normal 97-skill synchronization/drift check and all six packaged UI/team integration cases passed. These exercise actual offline payload copying, the 40-skill portable UI asset closure, isolated routing/Pro Max helpers, command rendering and native-definition preservation. Commit formatting/ESLint hooks passed.
Earlier repository documentation validation passed. The earlier broad lint run stopped on 50 bundled creator diagnostics; broad lint and the full installed Electron application were not rerun on this merge. Native Windows and every live harness remain unverified. These gaps are recorded; this PR is not release certification.
Evidence: .agent-team/boss-core/ui-routing-packaged-evidence.json, ui-routing-pin-sync-evidence.json and ui-routing-clean-clone-closure.json.
The final mini pin also includes documentation-only clarification of absent upstream/proposed scripts; six mini carried-payload checks pass. Companion mini CI still reports failures present on main; see mini #3. Current hosted Boss checks may still be pending or failing; the local evidence above is not a claim that hosted CI passed.
Merge coordination
Merge mini #3 first. Prefer a merge commit there to preserve this exact pinned revision; if mini is squash/rebase merged, update this PR's submodule and both integration-manifest pins before merging.
Companion full pack #102 can merge independently. This PR targets main and leaves the merge action to the maintainer.
Breaking changes
No intentional product API break. Impeccable's native engine is not bundled in mini; the bounded core adaptation is explicitly identified.
Release note