#141 fix: preserve maximized state when restoring inactive EVE clients - #140
Open
XiaomaiTX wants to merge 1 commit into
Conversation
- Preserve the window state across asynchronous double activation. - Restore previously maximized clients with SW_SHOWMAXIMIZED. - Avoid saving layouts for minimized clients. - Clear cached window state when clients exit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the loss of maximized state when restoring EVE clients that were automatically minimized as inactive.
Root cause
Preview activation may trigger two consecutive activation calls. Because
ShowWindowAsyncis asynchronous, the second call can still observe the window as minimized. The previous implementation removed the cached pre-minimize state during the first call, causing the second call to useSW_RESTOREinstead of restoring the client as maximized.Changes
SW_SHOWMAXIMIZED.SW_RESTOREfor clients that were not maximized.Verification
No Animation+ minimized inactive clients.Original Animation+ minimized inactive clients.Risk
The change only affects restoration of windows that EVE-O Preview has minimized. Normal window activation and manually managed window states retain their existing behavior.