refactor(structure): reorganize modules and improve documentation#15
Open
lore-is-already-taken wants to merge 4 commits into
Open
refactor(structure): reorganize modules and improve documentation#15lore-is-already-taken wants to merge 4 commits into
lore-is-already-taken wants to merge 4 commits into
Conversation
- Update core dependencies (fastapi, openai, uvicorn, etc.) to latest versions - Remove unused dependencies to reduce package bloat - Add new required dependencies (cryptography, grpcio-status, h2) - Update firebase-admin package name and version
- Reorder imports following PEP 8 conventions - Split long lines for better readability - Add trailing commas and proper spacing - Fix string concatenation style - Add missing newlines at end of files - Remove unused watchfiles dependency
… documentation - Move firebase.py to app/firebase/firestore.py for better package organization - Update import paths to reflect new module structure - Add docstrings to all functions (get_emg_context, ping, websocket_server, upload_image) - Add inline comments explaining code flow and functionality - Translate Spanish comments to English for consistency
- Replace global Firestore initialization with FirestoreHandler class - Add comprehensive logging configuration and structured logging - Replace print statements with logger calls - Improve error handling in Firestore initialization - Add type hints for better code maintainability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor codebase structure and improve code quality: