cleanup: delete orphan Phase-1/5 scaffold modules#47
Conversation
Remove the never-wired "new architecture" scaffold from early direct pushes: - core/runner.py (run_adapters, filter_findings) - policy/filter.py (apply_policy, policy_from_config) - policy/architecture.py (run_architecture_policy) Imported by zero src (verified across all repos), superseded by the live cli/runner.py + detectors/structure.py path before they were ever wired. Delete their 4 coupled test files; rewrite test_adapter_base.py to cover the LIVE ToolAdapter base + find_tool directly (they were only test-referenced via the orphan pipeline, so a wholesale delete would have tripped T1). The ToolAdapter base — used by all 8 live adapters — is kept. 1119 tests pass; ty clean; audit clean (B2 environmental only). Part of the cross-repo incomplete-integration remediation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
['Lost test coverage for core registry functions: TestGetEnabledAdapters tests were removed entirely. These test |
The orphan modules removed in the previous commit were excluded from D12 in .custodian/config.yaml; with the files gone those globs match nothing and `custodian doctor` flags them as stale (exit 1). Remove the three stale entries, keeping core/finding.py (its Finding helper methods are still live D12 matches). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Needs human attention (reason= reviewer process exited with rc=1 for state_key=Custodian-47 (stdout_tail="You've hit your session limit · resets 5:10am (America/New_York)") |
Part of the cross-repo incomplete-integration remediation (Phase 3 — DELETE).
Removes the never-wired "new architecture" scaffold from early direct pushes:
core/runner.py(run_adapters,filter_findings)policy/filter.py(apply_policy,policy_from_config)policy/architecture.py(run_architecture_policy)Verified safe: imported by zero src across all repos (cross-repo grep), superseded by the live
cli/runner.py+detectors/structure.pypath before they were ever wired. The introducing commits (caadf29,f69db99) were direct pushes that honestly labelled them "additive only / stubs / alongside legacy" — no false-completion claim.Their 4 coupled test files are removed;
test_adapter_base.pyis rewritten to cover the liveToolAdapterbase +find_tooldirectly — they were only test-referenced via the orphan pipeline, so a wholesale delete would have tripped T1 (the base is used by all 8 live adapters and must keep coverage).Verified: 1119 tests pass, ty clean, audit clean (only the environmental B2 boundary artifact remains).
🤖 Generated with Claude Code