Skip to content

cleanup: delete orphan Phase-1/5 scaffold modules#47

Merged
ProtocolWarden merged 2 commits into
mainfrom
cleanup/delete-orphan-scaffold-modules
Jun 18, 2026
Merged

cleanup: delete orphan Phase-1/5 scaffold modules#47
ProtocolWarden merged 2 commits into
mainfrom
cleanup/delete-orphan-scaffold-modules

Conversation

@ProtocolWarden

Copy link
Copy Markdown
Owner

Part of the cross-repo incomplete-integration remediation (Phase 3 — DELETE).

Removes the never-wired "new architecture" scaffold from early direct pushes:

  • core/runner.py (run_adapters, filter_findings)
  • policy/filter.py (apply_policy, policy_from_config)
  • policy/architecture.py (run_architecture_policy)

Verified safe: imported by zero src across all repos (cross-repo grep), superseded by the live cli/runner.py + detectors/structure.py path before they were ever wired. The introducing commits (caadf29, f69db99) were direct pushes that honestly labelled them "additive only / stubs / alongside legacy" — no false-completion claim.

Their 4 coupled test files are removed; test_adapter_base.py is rewritten to cover the live ToolAdapter base + find_tool directly — they were only test-referenced via the orphan pipeline, so a wholesale delete would have tripped T1 (the base is used by all 8 live adapters and must keep coverage).

Verified: 1119 tests pass, ty clean, audit clean (only the environmental B2 boundary artifact remains).

🤖 Generated with Claude Code

Remove the never-wired "new architecture" scaffold from early direct pushes:
- core/runner.py (run_adapters, filter_findings)
- policy/filter.py (apply_policy, policy_from_config)
- policy/architecture.py (run_architecture_policy)

Imported by zero src (verified across all repos), superseded by the live
cli/runner.py + detectors/structure.py path before they were ever wired. Delete
their 4 coupled test files; rewrite test_adapter_base.py to cover the LIVE
ToolAdapter base + find_tool directly (they were only test-referenced via the
orphan pipeline, so a wholesale delete would have tripped T1). The ToolAdapter
base — used by all 8 live adapters — is kept.

1119 tests pass; ty clean; audit clean (B2 environmental only).

Part of the cross-repo incomplete-integration remediation.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ProtocolWarden

ProtocolWarden commented Jun 18, 2026

Copy link
Copy Markdown
Owner Author

Resolved: superseded by new push — re-review resumed

Self-review concerns — auto-fixing (up to 6 attempts; re-queued if still unresolved):

['Lost test coverage for core registry functions: TestGetEnabledAdapters tests were removed entirely. These test get_enabled_adapters() from custodian.adapters.registry, which is NOT being deleted. The tests cover critical functionality (adapter instantiation, tool enable/disable logic, config parsing). The PR does not explain where this function is now tested, if anywhere.', 'Unexplained test removal: Tests like test_ruff_enabled_returns_ruff_adapter and test_vulture_enabled_returns_vulture_adapter verify that specific tool adapters are correctly instantiated based on config. These should remain part of the live test suite unless moved elsewhere (not shown in diff).', 'Integration test loss: test_integration_pipeline.py deletion removes end-to-end pipeline verification (adapters → filter → report). While the deleted orphan code may justify this, consider whether any integration coverage remains elsewhere.']

The orphan modules removed in the previous commit were excluded from D12 in
.custodian/config.yaml; with the files gone those globs match nothing and
`custodian doctor` flags them as stale (exit 1). Remove the three stale entries,
keeping core/finding.py (its Finding helper methods are still live D12 matches).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ProtocolWarden

Copy link
Copy Markdown
Owner Author

Needs human attention (reason=reviewer_backend_unavailable). Left open — not merged (unresolved) and not closed (work preserved).

reviewer process exited with rc=1 for state_key=Custodian-47 (stdout_tail="You've hit your session limit · resets 5:10am (America/New_York)")

@ProtocolWarden ProtocolWarden merged commit 54e1c1b into main Jun 18, 2026
6 of 7 checks passed
@ProtocolWarden ProtocolWarden deleted the cleanup/delete-orphan-scaffold-modules branch June 18, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant