Repository navigation
feat: add ZSTD network compression support and dynamic compression detection - #104
Merged
Merged
Conversation
Collaborator
Author
|
@Protryon The Cargo.toml specifies |
Protryon
approved these changes
Nov 6, 2026
Owner
|
Thanks, I'll do a CI refresh and re-release today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern ClickHouse instances use ZSTD by default (network_compression_method = 'zstd'), which previously caused the client to crash with a protocol error. Now, it dynamically detects whether the incoming packet is LZ4 or ZSTD and decodes it on the fly. I also fixed some minor double-allocation errors in compress_data.
Run any heavy SELECT query. It should fetch data successfully instead of throwing ProtocolError / UnexpectedEof.
P.S. Ran into an unpleasant issue in production today, which is why I’m here :)
klickhouse::client: clickhouse client failed: Io(Custom { kind: UnexpectedEof, error: ProtocolError("unexpected compression algorithm identifier: '90', expected 82 (LZ4)") })P.S.S. I think we should also remove the CompressionMethod requirement for 'None'. Let it automatically check all ClickHouse packet headers so it can determine on its own whether compression is needed or not