Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion src/mcproof/domain_protocol.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@
"UNVERIFIED_CALLER_BOUNDS",
}
)
RECOGNIZED_CERT_STATUSES: frozenset[str] = NON_VERIFIED_SUBTIERS | frozenset(
{"VERIFIED", "PROVEN", "REJECTED"}
)

ALLOWLISTED_SANDBOX_MODULES: frozenset[str] = frozenset(
{
Expand Down Expand Up @@ -643,6 +646,22 @@ def audit_transition_certificate(
findings: list[dict[str, str]] = []
status = str(cert.get("epistemic_status", "")).strip().upper()
proof_mode = str(cert.get("proof_mode", "")).strip().lower()

# An omitted or invented status has no checks to fail, so it must not pass.
if not status:
findings.append(
{
"rule": "CERT_STATUS_ABSENT",
"message": "Certificate omits epistemic_status.",
}
)
elif status not in RECOGNIZED_CERT_STATUSES:
findings.append(
{
"rule": "CERT_STATUS_UNKNOWN",
"message": f"epistemic_status {status!r} is not a recognized certificate status.",
}
)
prior_status = str(cert.get("prior_status", "")).strip().upper()
evidence_kind = str(cert.get("evidence_kind", "")).strip().lower()

Expand Down Expand Up @@ -861,9 +880,16 @@ def audit_transition_certificate(
)

passed = len(findings) == 0
# Do not relabel a lower bound, a conjecture, or a rejection as VERIFIED.
if not passed:
out_status = "REJECTED"
elif status in ("VERIFIED", "PROVEN"):
out_status = "VERIFIED"
else:
out_status = status
return {
"passed": passed,
"epistemic_status": "VERIFIED" if passed else "REJECTED",
"epistemic_status": out_status,
"finding_count": len(findings),
"findings": findings,
}
Expand Down
76 changes: 76 additions & 0 deletions tests/test_audit_status_fail_closed.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
"""An empty or unknown certificate must not come back VERIFIED.

The auditor used to return VERIFIED whenever it found no red-flag field.
A certificate with no status has no such field, so `{}` passed. The same
path relabeled REJECTED and CONJECTURE as VERIFIED.
"""

from __future__ import annotations

import io
import json
import sys
from pathlib import Path

from mcproof.cli import main as cli_main
from mcproof.domain_protocol import audit_transition_certificate

from helpers import expect_eq, expect_false, expect_in, expect_true

HEX64 = "a" * 64


def _rules(cert: dict) -> list[str]:
return [f["rule"] for f in audit_transition_certificate(cert)["findings"]]


def test_empty_certificate_is_rejected() -> None:
result = audit_transition_certificate({})
expect_false(result["passed"])
expect_eq(result["epistemic_status"], "REJECTED")
expect_in("CERT_STATUS_ABSENT", _rules({}))


def test_unknown_status_is_rejected() -> None:
cert = {"epistemic_status": "BANANA"}
result = audit_transition_certificate(cert)
expect_false(result["passed"])
expect_eq(result["epistemic_status"], "REJECTED")
expect_in("CERT_STATUS_UNKNOWN", _rules(cert))


def test_rejected_and_conjecture_are_not_relabeled_verified() -> None:
rejected = audit_transition_certificate({"epistemic_status": "REJECTED"})
expect_true(rejected["passed"], f"a plain rejection is not an illegal claim: {rejected}")
expect_eq(rejected["epistemic_status"], "REJECTED")

conjecture = audit_transition_certificate({"epistemic_status": "CONJECTURE"})
expect_true(conjecture["passed"], f"CONJECTURE does not require pins: {conjecture}")
expect_eq(conjecture["epistemic_status"], "CONJECTURE")


def test_verified_with_pins_still_passes() -> None:
cert = {
"epistemic_status": "VERIFIED",
"witness_or_proof_sha256": HEX64,
"tcb_pins": {"tcb_manifest_verified": True, "checker_sha256": HEX64},
}
result = audit_transition_certificate(cert)
expect_true(result["passed"], f"pinned VERIFIED certificate rejected: {result}")
expect_eq(result["epistemic_status"], "VERIFIED")


def test_cli_rejects_empty_certificate(tmp_path: Path) -> None:
path = tmp_path / "empty.json"
path.write_text("{}\n", encoding="utf-8")
old = sys.stdout
sys.stdout = io.StringIO()
try:
code = cli_main(["--json", "audit-cert", str(path)])
raw = sys.stdout.getvalue()
finally:
sys.stdout = old
expect_eq(code, 1)
parsed = json.loads(raw)
expect_eq(parsed["epistemic_status"], "REJECTED")
expect_false(parsed["passed"])
Loading