Repository navigation
Add Verified Bar review for zip (1cbcc1f) and cross-library path predicate check - #36
Conversation
Documented findings and required fixes for the bar audit of Proven-Commons/zip at commit 1cbcc1f, including issues related to NUL-byte parsing, symlink attributes, and overlapping local offsets.
|
Checked this audit at PR head
NUL acceptance, stronger path-component theorems, and repeated local offsets remain useful concerns to test against the actual code. For Z-F4, Suggested next step: replace the nonexistent paths/predicates, correct the proof and I/O scope, and commit the binary fixtures plus commands behind each AI-assisted source review of the pinned tree and PR diff. I did not run Lean or reproduce the audit's unpublished binary fixtures. |
Replace citations of nonexistent Zip/Safe.lean and SafeName predicates with ZipPilot/Path.lean, Header.lean, and Archive.lean. Downgrade un reproduced claims to CONCERN/UNVERIFIED, note no bar.toml and in-memory-only extraction, and drop findings that do not apply at the pinned revision. Co-authored-by: ahraz <ahrazzle@users.noreply.github.com>
zero-aska
left a comment
There was a problem hiding this comment.
Approve at c504b56. Docs only (reviews/zip/2026-11-11-bar-audit.md), rewritten against the real zip files at 1cbcc1f: Z-F2 and Z-F5 not applicable, Z-F1, Z-F3 and Z-F4 left CONCERN/UNVERIFIED rather than claimed. CI green at this head.
Adds
reviews/zip/2026-11-11-bar-audit.mddocumenting five verified specification and parser-differential findings (Z-F1throughZ-F5) onProven-Commons/zipat1cbcc1f(plus the shared0x00NUL-bytePlainNamenote forProven-Commons/tarPR #6), following the format established inreviews/tar/2026-10-24-bar-audit.md.Leaving unmerged for independent maintainer review per
MERGE-SOP.md.