Repository navigation
Add the Apache License 2.0 - #3
Merged
Merged
Conversation
zero-aska
marked this pull request as ready for review
October 29, 2026 19:25
zero-aska
approved these changes
Oct 29, 2026
zero-aska
left a comment
Contributor
There was a problem hiding this comment.
Approving as a maintainer who did not write this, under MERGE-SOP.
No blocking findings. This approval is for head 9802de7. The PR is still a draft, so it can merge only after it is marked ready.
What I checked:
- The whole diff against main is two files: a new LICENSE and one added line in lakefile.toml. The merge of main into the branch adds nothing else. It merges cleanly.
- LICENSE is byte-identical to the Apache-2.0 text from apache.org (sha256 cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30).
- lakefile.toml sets
license = "Apache-2.0"in the package table. Lake 4.35 reads it:lake translate-config leanprintslicense := "Apache-2.0". bar/check.py --offline --no-leangives the same report on main and on this head. Item 4 passes.- The bar CI check passed on this head.
- The Go, Node and Python oracles are original and only call the standard libraries.
- The PR text matches the policy in mission#26 and makes no claim that the library is verified.
- No other open PR in this repo.
Non-blocking, but worth a follow-up soon:
- The tree holds material copied from Go. Spec.lean (
go_clean_tests,go_join_tests) and tests/run_tests.py (GO_CLEAN,GO_JOIN) copy thecleantestsandjointeststables from src/path/path_test.go, go1.24.7. Spec.lean also keeps Go's section comments. SPEC.md and Spec/Defs.lean quote the doc comment of path.Clean. Each names its source, but none carries The Go Authors' copyright or names Go's BSD-3-Clause license. To see it:git grep -n path_test.goandgit grep -n -i -E 'copyright|BSD'(the second finds nothing). - This does not block the PR. The material was on main before, this PR does not touch it, and the policy says a repository's license does not relicense copied material. A follow-up should add Go's copyright line and BSD-3-Clause notice next to the copied tables and the quote, so that material carries its own license as mission#26 asks.
- The policy text (mission#26) is not merged yet. The owner's choice in mission#9 is enough for this change.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Apache License 2.0 for this repository's original code and documentation. Contributors retain their copyright. Existing notices for third-party material remain applicable.
Part of Proven-Commons/mission#9. The license text matches the organization source exactly; any Lake metadata change is checked by parsing the TOML.