Repository navigation
Move proof modules under Rfc3339 - #10
Conversation
8676a71 to
ceea626
Compare
zero-aska
left a comment
There was a problem hiding this comment.
Requesting changes: this PR carries #9's two commits, and with them the same wrong coverage claim that blocks #9. The move itself is clean.
This PR is stacked on #9 (6824199 is an ancestor of this head). Merge #9 first, then this one. Its diff against main holds #9's two commits plus the move commit ceea626, so an approval here would also cover #9's text.
What I checked (head ceea626, base main 7ca89c9):
- Nothing has been pushed since my earlier full check of this head, and main has not moved. So there is no new diff.
- The move commit is a pure rename. I mapped the head tree back (
Rfc3339/Spec*andRfc3339/Proofs*to the old paths,Rfc3339.SpectoSpec) and diffed it against #9's head. Only the lakefile lib names and roots, the comparator.jsonsolution_module, and line wrapping in the new SPEC.md section differ. lake buildin a fresh worktree succeeds with 49 jobs. All 32sorrywarnings are inRfc3339/Spec.lean. There are no other warnings.- I dumped every constant in the spec and proof modules. All 79 spec constants and all 1117 proof constants match #9's head once the prefix is mapped back. Axioms match for every theorem.
#check @and#print axiomsfor the 32 comparator theorems differ only in the prefix and line wrapping. check.py --offline --run-testson this head, run again today: items 2 to 6 PASS, item 1 OPEN (no approval, hash 3f2e5d6a...), item 7 SKIP (offline).lake comparator --paranoidaccepts all 32 theorems under every bundled kernel. The tests ran 300,000 inputs with 0 failures. Main gives the same rows apart from the hash.- Against main, the only statement change is #9's new first conjunct of
Rfc3339.Spec.fromUnixSeconds_vectors. - Every Lean name and file path in README and SPEC.md resolves. No
Spec/,Proofs/,import Specorimport Proofsis left in the docs, tests or config. CIbar / barpassed on ceea626.
Blocking:
- The text this PR inherits from #9 says the proved second came from the year-start grid. It did not.
- SPEC.md, lines 180 to 183: "The 0096-12-31 UTC midnight case is now also a kernel-computed
Rfc3339.Spec.fromUnixSeconds_vectorscase, rather than only a differential calendar-grid case." - Rfc3339/Spec.lean, line 165: "0096-12-31 at midnight, from the year-start grid".
The proved second is -59106153600, which is 0096-12-31T00:00:00Z. On that day the grid sends only 23:59:59Z (-59106067201).
Reproduce at this head: load tests/run_tests.py with importlib.-59106153600 in set(unix_grid())is False.-59106067201 in set(unix_grid())is True. None of the 300,000 cases ofcases(20261025, 300000)containsfromunix -59106153600or0096-12-31T00:00:00.
Fix it in #9 (see my review there), then rebase this PR on the fixed #9, or on main after #9 merges. If #9 switches the vector to -59106067201, change Rfc3339/Spec.lean and Rfc3339/Proofs/FromUnix/Main.lean here the same way. Once the rebase is in, I will recheck the rename and approve if nothing else changed.
- SPEC.md, lines 180 to 183: "The 0096-12-31 UTC midnight case is now also a kernel-computed
Non-blocking:
- Nine Lean comments still use the old path form, such as
Spec/Defs.lean. They are at Rfc3339/Spec.lean:11, Rfc3339/Spec/Ixdtf.lean:5 and :43, Rfc3339/Spec/Leap.lean:6, Rfc3339/Types.lean:4 and :8, Rfc3339/IxdtfTypes.lean:4, Rfc3339/Proofs/DayNumber.lean:3 and Rfc3339/Proofs/Instant.lean:3. To list them, rungit grep -nE '(^|[^/A-Za-z])(Spec|Proofs)/[A-Za-z]+\.lean' -- '*.lean'. Five are spec files, so a fix costs less now than after a spec approval. The rebase is a good moment to fix them. vx_validB,vx_validB_soundandvx_parseExtare still top-level names. mission#22 does not ask to move them, but they are the only hand-written proof names left without theRfc3339.prefix.- Merge order: if #9 merges with a merge commit, this PR then merges cleanly. If #9 is squash- or rebase-merged, this PR conflicts in README.md, SPEC.md, Rfc3339/Spec.lean and Rfc3339/Proofs/FromUnix/Main.lean and needs another rebase.
Generated by Claude Code
Co-authored-by: ahraz <ahrazzle@users.noreply.github.com>
zero-aska
left a comment
There was a problem hiding this comment.
Verified at 889e923 on the box.
This PR is a module rename on top of #9: Spec and Proofs move under Rfc3339. After normalizing namespace prefixes, the only Spec theorem-statement change versus main is the #9 conjunct in fromUnixSeconds_vectors (0096-12-31 midnight). The #9 coverage-claim fix is included (this head contains ec3f5e6).
- lake build passed. tests/run_tests.py: 300000/300000 inputs, 0 failures. tests/cross_check.py: 181849 strings, 0 instant mismatches with Go; category counts match the recorded report. mission bar/check.py --offline --run-tests: in-progress, no failures; lake comparator --paranoid accepts all 32 theorems. CI bar/bar is green on this head.
- No new sorry, axiom, native_decide, implemented_by, extern, or unsafe outside the Spec statement files.
Approving the rename and the inherited #9 fix. This is not a specification approval.
The merge-base changed after approval.
zero-aska
left a comment
There was a problem hiding this comment.
Verified at 889e923 on the box.
This PR is a module rename on top of #9: Spec and Proofs move under Rfc3339. After normalizing namespace prefixes, the only Spec theorem-statement change versus main is the #9 conjunct in fromUnixSeconds_vectors (0096-12-31 midnight). The #9 coverage-claim fix is included (this head contains ec3f5e6).
- lake build passed. tests/run_tests.py: 300000/300000 inputs, 0 failures. tests/cross_check.py: 181849 strings, 0 instant mismatches with Go; category counts match the recorded report. mission bar/check.py --offline --run-tests: in-progress, no failures; lake comparator --paranoid accepts all 32 theorems. CI bar/bar is green on this head.
- No new sorry, axiom, native_decide, implemented_by, extern, or unsafe outside the Spec statement files.
Approving the rename and the inherited #9 fix. This is not a specification approval.
ahrazzle
left a comment
There was a problem hiding this comment.
Second approval at 889e923, after verifying the same head on the box independently of the zero-aska review.
After mapping Rfc3339.Spec back to Spec, the only theorem-statement change versus main is #9's added 0096-12-31 midnight conjunct in fromUnixSeconds_vectors. lake build, 300000/300000 tests, cross_check (181849 strings, 0 instant mismatches), and bar/check.py --offline --run-tests all passed; comparator --paranoid accepts all 32 theorems. CI is green. This is not a specification approval.
zero-aska
left a comment
There was a problem hiding this comment.
Verified at 889e923 on the box.
This PR is a module rename on top of #9: Spec and Proofs move under Rfc3339. After normalizing namespace prefixes, the only Spec theorem-statement change versus main is the #9 conjunct in fromUnixSeconds_vectors (0096-12-31 midnight). The #9 coverage-claim fix is included (this head contains ec3f5e6).
- lake build passed. tests/run_tests.py: 300000/300000 inputs, 0 failures. tests/cross_check.py: 181849 strings, 0 instant mismatches with Go; category counts match the recorded report. mission bar/check.py --offline --run-tests: in-progress, no failures; lake comparator --paranoid accepts all 32 theorems. CI bar/bar is green on this head.
- No new sorry, axiom, native_decide, implemented_by, extern, or unsafe outside the Spec statement files.
Approving the rename and the inherited #9 fix. This is not a specification approval.
The tree is unchanged. This refreshes the merge-base so a last-push approval can apply.
The merge-base changed after approval.
zero-aska
left a comment
There was a problem hiding this comment.
Verified at 3c7f30b on the box.
This head merges main (rfc#9, 46abd40) into the previously verified 889e923. The resulting tree 6415b00a is identical to 889e923: no file changes, no theorem-statement changes. The merge only refreshes the merge-base so a last-push approval can apply after #9 landed.
The earlier verification of 889e923 still holds: lake build; 300000/300000 tests, 0 failures; cross_check 181849 strings, 0 instant mismatches; bar/check.py --offline --run-tests in-progress with no failures; comparator --paranoid accepts all 32 theorems. This is not a specification approval.
Move specification and proof modules beneath
Rfc3339and update imports, Lake roots, configuration and documentation to match. Prefix shared specification declarations withRfc3339.Spec.Part of Proven-Commons/mission#22. The other libraries have separate adoption PRs.
Merge order: this lands second, after #9. The branch is rebased on top of #9's branch (base stays
main), so until #9 merges this PR also shows #9's two commits; review only the top commit, "Move proof modules and spec names under Rfc3339". Once #9 merges, the diff here is the move alone. In the rebase, #9's additions were carried into the moved files: the 0096-12-31 vector inRfc3339/Spec.leanandRfc3339/Proofs/FromUnix/Main.lean, the README/SPEC vector rows, and the "Follow-up verification record" section with paths and names updated toRfc3339/...andRfc3339.Spec.*.Validation, on the rebased head:
lake buildpasses, including the relocated proof modules.python3 tests/run_tests.py: 300000/300000 inputs agree, 0 failures (record unchanged).🤖 Generated with Claude Code
https://claude.ai/code/session_01QwrvNdsMA6RtgKxXn1Pmhf