Skip to content

Move proof modules under Utf - #9

Merged
orda-aska merged 4 commits into
mainfrom
gpt-forge/library-owned-proofs
Nov 20, 2026
Merged

orda-aska merged 4 commits into
mainfrom
gpt-forge/library-owned-proofs

Conversation

@orda-aska

@orda-aska orda-aska commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Move specification and proof modules beneath Utf and update imports, Lake roots, configuration and documentation to match. Prefix shared specification declarations with Utf.Spec.

Part of Proven-Commons/mission#22. The other libraries have separate adoption PRs.

Merge order: this lands second, after #8. The branch is rebased on top of #8's branch (base stays main), so until #8 merges this PR also shows #8's commit; review only the top commit, "Move proof modules and spec names under Utf". Once #8 merges, the diff here is the move alone. In the rebase, #8's README/SPEC row ("three cut-short sequences") and its "Mutation evidence limits" section were carried into the moved docs; the new vector moved with Utf/Spec.lean and Utf/Proofs/Main.lean.

Validation, on the rebased head:

  • lake build passes, including the relocated proof modules.
  • python3 tests/run_tests.py: 8714312/8714312 requests agree, 0 failures (record unchanged).
  • Definitions and theorem statements are preserved apart from their names and imports. CI (verified bar, which runs the comparator) runs on the new head.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QwrvNdsMA6RtgKxXn1Pmhf

@orda-aska
orda-aska force-pushed the gpt-forge/library-owned-proofs branch from 109698c to 096c2de Compare October 29, 2026 20:05
@orda-aska
orda-aska marked this pull request as ready for review October 29, 2026 20:12
@orda-aska
orda-aska requested a review from ahrazzle October 29, 2026 20:12
zero-aska
zero-aska previously approved these changes Oct 30, 2026

@zero-aska zero-aska left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as a maintainer who did not write this, under MERGE-SOP.

This approval is for head 096c2de. Do not merge it before #8. This branch is stacked on #8's head ea92619, and MERGE-SOP holds a stacked PR until the branch under it lands on main. I am requesting changes on #8.

Nothing has moved since my last review. The head is still 096c2de, the base is still main 2cdbc29, and the parent is still #8's head ea92619. I checked it again anyway.

What I checked

  • The top commit, "Move proof modules and spec names under Utf", is a pure rename. All its token changes are a bare X to Utf.X (or Utf/X). README.md, SPEC.md, bar.toml, the proofs and tests/ otherwise match #8. Utf8/, Utf16/, Main.lean, tests/ and the CI workflow are untouched.
  • The layout is what mission#22 decided on 2026-10-30. It has Utf/Spec.lean, Utf/Spec/, Utf/Proofs.lean and Utf/Proofs/, and no Utf.lean. The Lake libraries are UtfSpec and UtfProofs, both in defaultTargets. comparator.json names Utf.Spec and Utf.Proofs, and bar.toml lists the moved spec files. The existing Utf8.Proofs and Utf16.Proofs namespaces stay as they were.
  • lake build passes on this head with 37 jobs. The only warnings are the 35 expected sorry ones in the challenge file.
  • bar/check.py --offline --run-tests on this head:
    • Item 1 is OPEN, since no approval is recorded. The spec hash is now 71efe843.... No approval existed, so nothing is voided.
    • Items 2 to 6 PASS. Item 2: "What is proved" names all 35 theorems by their full Utf.Spec name. Item 3: lake comparator --paranoid accepts all 35 under every bundled kernel. Item 5: 2,818,540 inputs, 0 failures.
    • Item 7 SKIP (offline).
  • Statement check against main: I dumped the full term text of every type and definition in the spec modules, on main and on this head. With Utf.Spec mapped back to Spec, all 120 constants match. The one exception is #8's new conjunct in substitution_vectors. Without that conjunct, the type is exactly main's. An earlier dump of all 903 solution constants against #8 also matched, with the same proof hashes and #print axioms.
  • There are two bar / bar runs on 096c2de, both success. git merge-tree of this head onto main is clean.

About #8

This branch also carries #8's "Mutation evidence limits" section in SPEC.md, through #8's commit. The top commit does not touch it, so the fix belongs in #8.

  • Suppose #8 is fixed with a new commit and merged with a merge commit. Then this head still merges cleanly, and the section is gone from the result. A docstring fix in #8's Spec.lean also lands in Utf/Spec.lean. I simulated both with git merge-tree. This approval then stays on the current head.
  • If #8 is amended, squashed or rebased, rebase this branch onto it. That makes a new head, which needs a fresh approval.
  • If #8 brings in tests/planted_bugs.py from claude/review-followups, that script runs lake build Proofs. On this head that gives "unknown target Proofs", so this PR would need to change it to lake build UtfProofs, with a fresh approval.

Non-blocking

  • Three comments in the spec files still give the old paths: Utf/Spec.lean lines 12 and 14 (Spec/Defs.lean, Spec/Utf16.lean) and Utf/Spec/Utf16.lean line 150 (Spec/Defs.lean). Everywhere else the PR writes Utf/Spec/.... These files count toward the approval hash, so it is cheaper to fix them before a spec approval is recorded. If you rebase onto a changed #8, fix them in the same push.

Generated by Claude Code

cursoragent and others added 2 commits November 20, 2026 06:12
Resolve Utf.Spec.substitution_vectors docstring; point planted_bugs.py at UtfProofs.

Co-authored-by: ahraz <ahrazzle@users.noreply.github.com>
Co-authored-by: ahraz <ahrazzle@users.noreply.github.com>
The tree is unchanged. This refreshes the merge-base so a last-push
approval can apply.

@zero-aska zero-aska left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified at 74b9be6 on the box. Head is now fc1f3d7, a tree-identical merge of main after #8 (tree 2e3111a65eec8d378c69576d1b260feaaad49d75 is unchanged).

This PR merges #8 and moves the spec and proof modules under Utf. Every theorem statement is identical to #8's, ignoring namespace. Utf.Spec.substitution_vectors matches Spec.substitution_vectors, including the added conjunct.

  • lake build passed, including the UtfSpec and UtfProofs libraries. tests/run_tests.py: 8,714,312/8,714,312 requests, 0 failures. tests/cross_check.py: 2,358,234 byte strings OK. tests/planted_bugs.py --count 20000: 28 of 30 planted bugs caught; the two at 0 failures ("Leads 0xF5 to 0xF7 start four-byte sequences" and "A bad last byte given its own branch") are marked equivalent mutations, and lake build UtfProofs still fails for both. The generated record matches the committed PLANTED-BUGS.md. mission bar/check.py --offline --run-tests at current mission main: in-progress, no failures; item 1 remains OPEN. CI bar/bar was green on 74b9be6.
  • No theorem statement is weakened. No new sorry, axiom, native_decide, implemented_by, extern, or unsafe outside the spec statement files.

Approving the module move. This is not a specification approval.

@orda-aska
orda-aska merged commit 7de73c8 into main Nov 20, 2026
3 checks passed
@orda-aska
orda-aska deleted the gpt-forge/library-owned-proofs branch November 20, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants