Repository navigation
Leave the notification listener out of the manifest when income is off (1.0.22) - #17
Merged
Merged
Conversation
…is off Google Play blocked the 1.0.21 release for BankNotificationListenerService. With FEATURE_INCOME off it shipped with android:enabled="false", but Play reviews the declared manifest, so a disabled listener -- and its BIND_NOTIFICATION_LISTENER_SERVICE permission -- still counts. When the flag is off, build.gradle now points each flavor's manifest at src/noIncome/AndroidManifest.xml, which removes the service with tools:node="remove". The flavors had no manifest of their own, so nothing else is overridden. One JSON file still drives Dart and Android; the featureIncome placeholder goes, since the service is either declared and on or not declared at all. Checked in the merged manifests of real builds: production (income off) declares neither the service nor the permission; development (income on) declares both. The one native call at startup, the listener rebind, returns early unless notification access is granted, which an undeclared service can never be. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google Play blocked 1.0.21 for
BankNotificationListenerService. WithFEATURE_INCOMEoff it shipped withandroid:enabled="false", but Play reviews the declared manifest, so a disabled listener and itsBIND_NOTIFICATION_LISTENER_SERVICEpermission still counted.When the flag is off,
build.gradlenow mergessrc/noIncome/AndroidManifest.xml, which removes the service withtools:node="remove".FEATURE_INCOMEChecked in the merged manifests of real builds. Bumps to 1.0.22+27, so merging releases it.
🤖 Generated with Claude Code