Repository navigation
Fix risk estimation using data before its arrival - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily bars and exposure fields with explicit late arrival times were relabeled as available at market close, allowing an evening price to affect an earlier risk estimate. The adapter now preserves price, feature, and entitlement availability, requires both return endpoints to have arrived, and applies the lookback after filtering available observations.
Existing callers without availability columns retain the assumed-close behavior, now explicitly labeled and documented as insufficient for historical PIT certification. No model parameters or production risk limits change.
Validation: 281 tests passed, 85.19% total coverage, Ruff passed. Eight new regression cases cover evening arrivals, late prior-price corrections, future feature values, late entitlements, invalid timestamps, and legacy parity. A separate adversarial comparison against the pre-fix main revision confirms that altering a not-yet-arrived price changes the old estimate but leaves the repaired estimate unchanged.