Skip to content

Specify main branch to push and pull request trigger#190

Merged
mrava87 merged 2 commits intoPyLops:mainfrom
rohanbabbar04:fix-build-cupy
Mar 25, 2026
Merged

Specify main branch to push and pull request trigger#190
mrava87 merged 2 commits intoPyLops:mainfrom
rohanbabbar04:fix-build-cupy

Conversation

@rohanbabbar04
Copy link
Copy Markdown
Collaborator

  • Add branch main to push and pull_request trigger

Just realized that the tests were running twice(one for push and another for pull_request) on every update of the PR.

@rohanbabbar04 rohanbabbar04 changed the title Add branches to push and pull request trigger Specify main branch to push and pull request trigger Mar 25, 2026
@mrava87
Copy link
Copy Markdown
Contributor

mrava87 commented Mar 25, 2026

Yup, I noticed the same recently but didnt get around fixing it... in pylops we do it right, I guess this is a leftover of our old way of running the CuPy CI in PyLops...

Could you change it to match https://github.com/PyLops/pylops-mpi/blob/main/.github/workflows/build.yml though.

@rohanbabbar04
Copy link
Copy Markdown
Collaborator Author

Yup, I noticed the same recently but didnt get around fixing it... in pylops we do it right, I guess this is a leftover of our old way of running the CuPy CI in PyLops...

Could you change it to match https://github.com/PyLops/pylops-mpi/blob/main/.github/workflows/build.yml though.

Just added the workflow_dispatch :)

@mrava87 mrava87 merged commit 66167e8 into PyLops:main Mar 25, 2026
50 checks passed
@rohanbabbar04 rohanbabbar04 deleted the fix-build-cupy branch March 25, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants