Skip to content

Conversation

@luxedo
Copy link
Contributor

@luxedo luxedo commented Feb 9, 2026

Part of #3908

Adds Sealed to traits in impl_/retrospection.rs

@luxedo luxedo marked this pull request as draft February 9, 2026 16:45
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching! Probably need to have a custom Sealed trait here unique to this trait, e.g. see extract_argument.rs.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Feb 11, 2026
@luxedo luxedo force-pushed the 3908/seal-introspection branch from e3c84e3 to d08f573 Compare February 11, 2026 19:30
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 11, 2026

Merging this PR will improve performance by 18.8%

⚡ 1 improved benchmark
✅ 98 untouched benchmarks
⏩ 1 skipped benchmark1

Performance Changes

Benchmark BASE HEAD Efficiency
format_simple 368.6 ns 310.3 ns +18.8%

Comparing luxedo:3908/seal-introspection (d08f573) with main (5338c48)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants