fix(version): report sluice's own version, not an enclosing repo's (v0.1.1)#13
Merged
Conversation
…0.1.1 + brew `git describe` at the install dir walked up to an enclosing git repo (e.g. Homebrew's /opt/homebrew), so a brew-installed `sluice -v` reported Homebrew's version. Only trust git when $ROOT is sluice's own checkout (.git present), else the baked SLUICE_VERSION. Also bump the baked version to 0.1.1, add `brew install Pyronewbic/tap/sluice` to the README (the tap is now live), and mark the in-repo formula a template (the tap is the source of truth).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cutting v0.1.1 to fix a version-reporting bug the Homebrew install surfaced.
Bug:
sluice_version()rangit describeat the install dir, butgitwalks up for a.git- and a brew install lives inside/opt/homebrew(a git repo), sosluice -vreported Homebrew's version (5.1.14) instead of sluice's. Now it only trusts git when$ROOTis sluice's own checkout (.gitpresent), else the bakedSLUICE_VERSION. Verified: a no-.gitinstall nested in another git repo now reports the baked version.Also: baked version -> 0.1.1;
brew install Pyronewbic/tap/sluiceadded to the README (the tap repo is now live); the in-repo formula is marked a template (the tap holds the sha-pinned formula).After merge: tag
v0.1.1-> release, then pin the tap formula to the v0.1.1 sha.