Skip to content

fix: prove canonical live harness opt-in#1214

Open
Q00 wants to merge 1 commit into
mainfrom
fix/canonical-live-harness-contract
Open

fix: prove canonical live harness opt-in#1214
Q00 wants to merge 1 commit into
mainfrom
fix/canonical-live-harness-contract

Conversation

@Q00
Copy link
Copy Markdown
Owner

@Q00 Q00 commented May 24, 2026

Summary

  • fixes feat(tests): canonical acceptance harness skeleton (L0-a) #1174 by updating the canonical summary/docs to reflect the live opt-in path as available
  • keeps the cli-todo fixture aligned with the L1 TaskClass catalog contract
  • adds a hermetic test proving OUROBOROS_RUN_CANONICAL=1 reaches the live runner instead of only skipping

Verification

  • uv run pytest tests/canonical/ -q
  • uv run ruff check tests/canonical/conftest.py tests/canonical/test_conftest.py tests/canonical/test_canonical.py

@Q00 Q00 force-pushed the fix/canonical-live-harness-contract branch from 559f7fc to 1483504 Compare May 24, 2026 10:59
Copy link
Copy Markdown
Contributor

@ouroboros-agent ouroboros-agent Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — ouroboros-agent[bot]

Verdict: APPROVE

Metadata

| Field | Value |
|### Recovery Notes
First recoverable review artifact generated from codex analysis log.

---|---|
| PR | #1214 |
| HEAD checked | 14835042245c34d52e8bd433b6f956de3b63d48b |
| Request ID | req_retry_exhausted_new_timeout_1779693693_1214 |
| Review record | 53a1bdf3-db26-4661-ae7d-42f4ddc14805 |

What Improved

  • Canonical harness status now advertises the live opt-in path.
  • Added hermetic coverage that the opt-in test path calls the live runner without spending LLM tokens.
  • Canonical metadata is now documented as validated against the L1 task-class catalog.

Issue Requirements

Requirement Status
#1170 canonical harness live opt-in documentation/coverage Satisfied by updated README/status line and hermetic opt-in invocation test.
#1157 canonical acceptance-gate scenario context Maintained; no conflicting runtime contract found.

Prior Findings Status

No prior human or inline review comments were present in the provided artifacts.

Blockers

No in-scope blocking findings remained after policy filtering.

Follow-up Findings

# File:Line Priority Confidence Suggestion
None.

Non-blocking Suggestions

| 1 | tests/canonical/conftest.py:3 | Documentation | The module docstring still says the actual ouroboros_auto invocation lands in a follow-up sub-PR, while this PR and test_canonical.py now describe the live opt-in path as available. This is stale internal documentation, not a runtime blocker. |

Test Coverage Notes

  • Reviewed tests/canonical/test_canonical.py, tests/canonical/test_conftest.py, tests/canonical/conftest.py, the scenario fixture, and relevant AutoHandler metadata contract.
  • Could not run uv run pytest tests/canonical/ -q: uv is not installed in the container.
  • Could not run python3 -m pytest: pytest is not installed.
  • Ran python3 -m py_compile on the changed Python files successfully.

Design Notes

The change stays scoped to the canonical acceptance harness and docs. The live path remains opt-in, preserving the no-cost default test boundary.

Design / Roadmap Gate

Affected boundary is test harness documentation plus the opt-in live-run contract. The default hermetic path still skips live execution unless OUROBOROS_RUN_CANONICAL is enabled. The new fake-invocation test exercises that the opt-in branch reaches _invoke_ouroboros_auto and does not broaden persistence or runtime behavior outside tmp_path.

Directional Notes

Focused on contract drift between docs, canonical metadata, L1 task-class catalog validation, and AutoHandler result metadata. Maintainer memory was advisory only; no blocker relies on it.

Test Coverage

  • Reviewed tests/canonical/test_canonical.py, tests/canonical/test_conftest.py, tests/canonical/conftest.py, the scenario fixture, and relevant AutoHandler metadata contract.
  • Could not run uv run pytest tests/canonical/ -q: uv is not installed in the container.
  • Could not run python3 -m pytest: pytest is not installed.
  • Ran python3 -m py_compile on the changed Python files successfully.

Merge Recommendation

Approve. I found no blocking runtime, contract, persistence, or test-harness issue in the changed boundary. The only issue is stale docstring text.

Review-Metadata:
verdict: APPROVE
head_sha: 1483504
request_id: req_retry_exhausted_new_timeout_1779693693_1214
review_profile: memory-aware-zero-trust-v2
advisory_memory_only: true


Reviewed by ouroboros-agent[bot] via Codex deep analysis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant