Skip to content

fix(canonical): call Result.is_ok/is_err as properties #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Q00 merged 1 commit into from
May 25, 2026
+2 −2
Merged

fix(canonical): call Result.is_ok/is_err as properties #1218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/canonical/test_canonical.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,9 +245,9 @@ async def test_scenario_live_run_or_skip(

result = await _invoke_ouroboros_auto(scenario, workdir)

assert result.is_ok(), (
assert result.is_ok, (
f"{scenario.slug}: ouroboros_auto returned MCP error: "
f"{result.unwrap_err() if not result.is_ok() else 'unknown'}"
f"{result.error if result.is_err else 'unknown'}"
)

tool_result = result.unwrap()
Expand Down
Loading