Skip to content

fix(auto): close safe-default synthesis ack #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Q00 wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −2
Open

fix(auto): close safe-default synthesis ack #1220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
684e11b
fix(auto): close safe-default synthesis ack
Q00 May 25, 2026
bc2ef97
fix(auto): block nonterminal safe-default synthesis
Q00 May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/ouroboros/auto/interview_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@

log = structlog.get_logger(__name__)

INTERVIEW_SAFE_DEFAULT_SYNTHESIS_STOP_REASON_CODE = "interview_safe_default_synthesis_nonclosure"


@dataclass(frozen=True, slots=True)
class InterviewTurn:
Expand Down Expand Up @@ -431,7 +433,11 @@ async def run(self, state: AutoPipelineState, ledger: SeedDraftLedger) -> AutoIn
synthesis_pushed=False,
)
state.ledger = ledger.to_dict()
state.mark_blocked(blocker, tool_name="interview.safe_default_synthesis")
state.mark_blocked(
blocker,
tool_name="interview.safe_default_synthesis",
error_code=INTERVIEW_SAFE_DEFAULT_SYNTHESIS_STOP_REASON_CODE,
)
record_authoring_backend(state)
self._save(state)
return AutoInterviewResult(
Expand All @@ -446,7 +452,11 @@ async def run(self, state: AutoPipelineState, ledger: SeedDraftLedger) -> AutoIn
"backend_done=False, ledger defaults rolled back"
)
state.ledger = ledger.to_dict()
state.mark_blocked(blocker, tool_name="interview.safe_default_synthesis")
state.mark_blocked(
blocker,
tool_name="interview.safe_default_synthesis",
error_code=INTERVIEW_SAFE_DEFAULT_SYNTHESIS_STOP_REASON_CODE,
)
record_authoring_backend(state)
self._save(state)
return AutoInterviewResult(
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/auto/test_interview_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,7 @@ async def answer(
assert result.status == "blocked"
assert state.interview_completed is False
assert "transcript sync failed" in (result.blocker or "")
assert state.last_error_code == "interview_safe_default_synthesis_nonclosure"
assert ledger.open_gaps()
assert not any(
entry.key == f"{section_name}.safe_default_finalization"
Expand Down Expand Up @@ -881,6 +882,7 @@ async def answer(
assert state.interview_completed is False
assert state.pending_question == "Still need one more thing"
assert "did not close the persisted interview" in (result.blocker or "")
assert state.last_error_code == "interview_safe_default_synthesis_nonclosure"
assert ledger.open_gaps()
assert not any(
entry.key == f"{section_name}.safe_default_finalization"
Expand Down
Loading