test(pm): assert MCP uncertainty guidance ordering

[Q00]

Summary\n\n- Adds direct MCP PM handler coverage for the uncertainty guidance start response.\n- Pins that PM_UNCERTAINTY_GUIDANCE appears before the first returned question.\n\n## Changes\n\n- Adds a focused test in tests/unit/mcp/tools/test_pm_handler.py.\n\n## Notes\n\nFollow-up for the non-blocking test coverage item on #1154.

[ouroboros-agent]

Review — ouroboros-agent[bot]

Verdict: APPROVE

Metadata

| Field | Value |
|### Recovery Notes
First recoverable review artifact generated from codex analysis log.

---|---|
| PR | #1223 |
| HEAD checked | df520820da64106dfdedc57bacc9aa3fa49cd6a1 |
| Request ID | req_1779704769_16 |
| Review record | d6db4d6c-3b6e-4a40-9b23-de5b6729e900 |

What Improved

• Adds regression coverage that the MCP PM interview start response presents PM_UNCERTAINTY_GUIDANCE before the first question.

Issue Requirements

Requirement	Status
PR body/title requirements	N/A
Add/maintain coverage for PM uncertainty guidance ordering in MCP start response	Met

Prior Findings Status

No prior ouroboros-agent[bot] review concerns were present in the provided artifact.

Blockers

No in-scope blocking findings remained after policy filtering.

Follow-up Findings

#	File:Line	Priority	Confidence	Suggestion
-	-	-	-	None.

Non-blocking Suggestions

| - | - | - | None. |

Test Coverage Notes

• Reviewed /tmp/pr_diff_1223.patch, changed file list, PR body, human comments, inline comments, prior bot reviews, changed test, and affected handler/source contracts.
• Current HEAD evidence: src/ouroboros/mcp/tools/pm_handler.py:849 builds start text as session banner, then PM_UNCERTAINTY_GUIDANCE, then the question. src/ouroboros/mcp/types.py:345 confirms text_content is the right MCP result surface for this assertion.
• Could not execute tests locally: python is unavailable, python3 lacks pytest, and uv is unavailable.

Design Notes

This is test-only coverage for an existing MCP response contract. It does not change runtime behavior, persistence, or public handler parameters.

Design / Roadmap Gate

Affected boundary is PMInterviewHandler.handle({"initial_context": ...}) returning MCP text content. The added test uses an injected engine, avoids LLM/network paths, persists via tmp_path, and checks the user-visible ordering that downstream MCP clients receive through MCPToolResult.text_content.

Directional Notes

Maintainer memory emphasized spec-first PM behavior and high-signal review findings. I focused on the PM/MCP boundary and verified the test asserts a real current-HEAD behavior rather than only duplicating implementation detail.

Test Coverage

• Reviewed /tmp/pr_diff_1223.patch, changed file list, PR body, human comments, inline comments, prior bot reviews, changed test, and affected handler/source contracts.
• Current HEAD evidence: src/ouroboros/mcp/tools/pm_handler.py:849 builds start text as session banner, then PM_UNCERTAINTY_GUIDANCE, then the question. src/ouroboros/mcp/types.py:345 confirms text_content is the right MCP result surface for this assertion.
• Could not execute tests locally: python is unavailable, python3 lacks pytest, and uv is unavailable.

Merge Recommendation

Approve. No blocking runtime, contract, or test-quality issue was found in the changed boundary.

Review-Metadata:
verdict: APPROVE
head_sha: df52082
request_id: req_1779704769_16
review_profile: memory-aware-zero-trust-v2
advisory_memory_only: true

---

Reviewed by ouroboros-agent[bot] via Codex deep analysis