Skip to content

add new package name for play store#423

Merged
Q7DF1 merged 1 commit into
mainfrom
feature/playstore
Jun 13, 2026
Merged

add new package name for play store#423
Q7DF1 merged 1 commit into
mainfrom
feature/playstore

Conversation

@Q7DF1

@Q7DF1 Q7DF1 commented Jun 12, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the build configuration to dynamically resolve the application ID using the APPLICATION_ID property, falling back to a default value. It also introduces a new APPLICATION_ID_PLAY property in gradle.properties. Feedback highlights that the newly added APPLICATION_ID_PLAY property is currently unused and suggests updating the lookup logic in build.gradle.kts to check for it before falling back to the default string.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread app/build.gradle.kts
val VERSION_NAME:String by project
val VERSION_CODE:String by project
applicationId = "com.android.xrayfa"
val APPLICATION_ID = findProperty("APPLICATION_ID") as String? ?: "com.android.xrayfa"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The newly added property APPLICATION_ID_PLAY in gradle.properties is currently unused. If the intention is to use it as a fallback when APPLICATION_ID is not explicitly provided, you should update the lookup to check for APPLICATION_ID_PLAY before falling back to the default package name.

        val APPLICATION_ID = findProperty("APPLICATION_ID") as String? ?: findProperty("APPLICATION_ID_PLAY") as String? ?: "com.android.xrayfa"

@Q7DF1 Q7DF1 merged commit 3014493 into main Jun 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant