add new package name for play store#423
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the build configuration to dynamically resolve the application ID using the APPLICATION_ID property, falling back to a default value. It also introduces a new APPLICATION_ID_PLAY property in gradle.properties. Feedback highlights that the newly added APPLICATION_ID_PLAY property is currently unused and suggests updating the lookup logic in build.gradle.kts to check for it before falling back to the default string.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| val VERSION_NAME:String by project | ||
| val VERSION_CODE:String by project | ||
| applicationId = "com.android.xrayfa" | ||
| val APPLICATION_ID = findProperty("APPLICATION_ID") as String? ?: "com.android.xrayfa" |
There was a problem hiding this comment.
The newly added property APPLICATION_ID_PLAY in gradle.properties is currently unused. If the intention is to use it as a fallback when APPLICATION_ID is not explicitly provided, you should update the lookup to check for APPLICATION_ID_PLAY before falling back to the default package name.
val APPLICATION_ID = findProperty("APPLICATION_ID") as String? ?: findProperty("APPLICATION_ID_PLAY") as String? ?: "com.android.xrayfa"
No description provided.