fix: gh api's 404 body landed in the URL for a repo with no Pages site - #27
Merged
Merged
Conversation
Caught by the first pull request that exercised the new default. templateHPC.jl has no Pages site,
and the comment it posted read
https://docs.github.com/rest/pages/pages#get-a-apiname-pages-site","status":"404"}/previews/PR9/
`gh api` writes its error JSON to STDOUT, `--jq` passes it through unfiltered, and `|| true`
hides the non-zero exit — so the fallback that exists for exactly this case never ran.
Checked for SHAPE now rather than for exit code. Dry-run on both:
no Pages site https://qatlashub.github.io/templateHPC.jl/previews/PR9/
Pages site https://qatlashub.github.io/SweepRunner.jl/previews/PR40/ (200)
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
sotashimozono
added a commit
to QAtlasHub/templateHPC.jl
that referenced
this pull request
Sep 9, 2026
A re-run reuses the reusable workflow at the ref the original run resolved, so it cannot pick up QAtlasHub/.github#27. A new event can.
sotashimozono
added a commit
to QAtlasHub/templateHPC.jl
that referenced
this pull request
Sep 9, 2026
…tes (#9) * chore: drop the preview-base override the reusable workflow now computes The default was `https://codes.sota-shimozono.com`, which resolves to `sinkhole.paloaltonetworks.com`, so this repository passed the right base by hand. QAtlasHub/.github#26 made the default ask the Pages API where the site actually is, which for this repository answers `https://qatlashub.github.io/templateHPC.jl/` — the same value this line was supplying. The preview comment on this pull request is the check: it should read `https://qatlashub.github.io/templateHPC.jl/previews/PR<N>/` with the override gone. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ci: re-run the preview with the fixed reusable workflow A re-run reuses the reusable workflow at the ref the original run resolved, so it cannot pick up QAtlasHub/.github#27. A new event can. --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caught by the first pull request that exercised the new default — QAtlasHub/templateHPC.jl#9, a repository with no Pages site. The comment it posted read:
gh apiwrites its error JSON to stdout,--jqpasses it through unfiltered, and|| truehides the non-zero exit — so the fallback written for exactly this case never ran.Checked for shape now, not for exit code. Dry-run on both:
https://qatlashub.github.io/templateHPC.jl/previews/PR9/https://qatlashub.github.io/SweepRunner.jl/previews/PR40/— 200🤖 Generated with Claude Code