docs: the preview-base example named the host that broke it - #28
Merged
Merged
Conversation
The commented-out override in the README showed `codes.sota-shimozono.com`, which is the value that was the workflow's default until #26 — and which resolves to `sinkhole.paloaltonetworks.com`. A reader copying the example would have re-created the bug. The default now asks the Pages API where the site is, so the override is for the case the API cannot answer: a site served from somewhere else. The example says that instead of naming a dead host. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commented-out override in the README showed
# with: { preview-base: https://codes.sota-shimozono.com }which is both the value that was this workflow's default until #26 and a name that resolves to
sinkhole.paloaltonetworks.com. A reader copying the example would have re-created the bug the default was just fixed for.The default now asks the Pages API where the site is, so the override exists for the case the API cannot answer — a site served from somewhere else. The example says that instead of naming a dead host.
Last remaining hit for
codes.sota-shimozono.comin this repository. Tracked in #23.🤖 Generated with Claude Code