Repository navigation
Seams found end to end, and a match is not taken at its word (0.4.3) - #48
Merged
Merged
Conversation
… (0.4.3) From running SweepRunner -> DataVault -> Pinax.report -> deposit on archeion-demo: - deposit takes the file Pinax.render/report returns (index.html, agent.json) as its directory. - a deposit that fails at any step, not only in provenance, leaves no _incoming/<rev>. - the built site leaves out provenance/ and repro/: at 79_500 points the table is 24.4 MiB per revision (4.5 MiB gzip; git packs a re-render at +0 and a full recompute at +4.3 MiB), and the site would carry it once per revision. provenance.toml is still served. - validate warns on a loaded-matches-disk from observation_version 1, whose check for code defined in a script never fired (DataVault 0.8.6). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…leanup failure A match cannot be shown from inside the computing process, and DataVault 0.8.6 stops writing one (DataVault#57). An earlier observation's loaded-matches-disk is now warned on and counted as unverified, in the deposited summary and in the check, rather than only warned on while the count kept it. A deposit whose cleanup rm fails rethrows the step's own error, not the rm's. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
sotashimozono
changed the title
…a warning Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by running the whole chain (SweepRunner with 2 workers → DataVault →
Pinax.report→deposit(...; provenance)) on archeion-demo, plus fixes from review:deposittakes the file a render returns.Pinax.renderandPinax.reportreturnindex.html/agent.json, whiledepositwanted their directories. A file now stands for its directory, and a missing directory is a clear error.No leftovers. A deposit that fails at any step removes
_incoming/<rev>, not only one that fails in provenance. If that cleanup itself fails, the step's own error is still what is raised.A lean site. At 79,500 points (synthetic, same shape as the real vault):
points.tsvper revision (raw / gzip)Git is fine. The site was the problem: it copied whole revision directories. It now leaves out
provenance/andrepro/, and still servesprovenance.toml.A match is not taken at its word. A match cannot be shown from inside the computing process: a recipe written in a script, a closure, or a method added to Base leaves nothing to check it against. DataVault 0.8.6 stops writing
loaded-matches-disk(Never claim loaded-matches-disk (0.8.6) DataVault.jl#57).loaded-matches-diskin a deposited observation is now warned on and counted asunverified, both in the summarydepositwrites and in the check.No new DataVault floor. Tests were run locally for the touched files (
test_provenance,test_deposit,test_build,test_validate: 95 checks pass). The full run is left to CI.🤖 Generated with Claude Code