Skip to content

@pinaxignore is skipped by the per-file table but counted in the page header, so the two disagree with no note #124

Description

@sotashimozono

_collect_rows! (src/testset.jl:1290) skips ignored subtrees entirely. _ntests / _nfail / _nbroken (:574-583) deliberately do not.

The page-level _summary_line(root) passed to _enter_page! (:1446) therefore counts tests that have no row in the table beneath it, and there is no "N ignored" note to explain the gap.

With the documented example -- src/testset.jl:139-143 shows @pinaxignore on an Aqua block -- the header total and the sum of the table simply disagree.

Fix

Either exclude ignored subtrees from both, or count them in both and render an explicit "N ignored" line so the difference is stated rather than left for the reader to notice.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingsilent-failureWrong output that looks self-consistent; no signal to the readertest-reportThe Test -> Pinax bridge (experimental)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions