chore: drop the preview-base override, and the comment explaining why it was there - #40
Merged
Merged
Conversation
… it was there The comment said the reusable workflow defaults to `codes.sota-shimozono.com`, which does not resolve — correct, and it stayed correct here while every other caller of that workflow kept posting a dead link. QAtlasHub/.github#26 fixed the default instead: it now asks the Pages API where the site is, which for this repository answers `https://qatlashub.github.io/SweepRunner.jl/`. Both the override and its explanation go, because the condition the explanation describes no longer holds and a comment that outlives its condition is worse than none. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
📚 Docs preview: https://qatlashub.github.io/SweepRunner.jl/previews/PR40/ (updates on each push to this PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repository's
DocsPreview.ymlcarried both the workaround and a note explaining it:That was right, and it stayed right here while the other five callers of the same workflow went on posting a dead link. QAtlasHub/.github#26 fixed the default instead — it asks the Pages API where the site actually is, which for this repository answers
https://qatlashub.github.io/SweepRunner.jl/.Both the override and its explanation go: the condition the comment describes no longer holds, and a comment that outlives its condition is worse than none.
The preview comment on this pull request is the check.
🤖 Generated with Claude Code