Repository navigation
Pass save!'s digest to mark_done!, so .done names the bytes each attempt wrote - #54
Merged
Merged
Conversation
…mpt wrote DataVault 0.8.3's save! returns the SHA-256 it took from the temporary file before the rename; _run_one_with_retry! now hands it to mark_done!(…; result), and the key_done event carries it too. Without it a version-2 marker says `result_sha256=unknown`. The DataVault floor moves to 0.8.3, where that API arrived. Version 0.6.5. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
📚 Docs preview: https://qatlashub.github.io/SweepRunner.jl/previews/PR54/ (updates on each push to this PR) |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataVault 0.8.3 (QAtlasHub/DataVault.jl#53) makes
save!return(; file, sha256), the digest taken from the temporary file before the rename, and letsmark_done!(…; result)write it into a version-2.done. This passes it through in_run_one_with_retry!, and adds it to thekey_doneevent.0.8.3. Version 0.6.5.test/run/test_run_result_digest.jl: afterrun!, every.doneis version 2 and itsresult_sha256/result_filematch the data file.test_run_minimal.jl(36) andtest_run_worker_load.jl(9, spawns workers, so the pmap path) pass.CI will not resolve until DataVault 0.8.3 is in General — JuliaRegistries/General#169052 is open. Re-run then.
This is the first step of stage C (per-point provenance); the per-process source observation and its binding come next.
🤖 Generated with Claude Code