Name work_fn as the entry code of every observation (0.6.7) - #56
Draft
sotashimozono wants to merge 1 commit into
Draft
sotashimozono wants to merge 1 commit into
sotashimozono wants to merge 1 commit into
Conversation
With DataVault 0.8.6 an observation is unverified unless its entry code is named and checked. run! now passes work_fn to observe_sources on the master and on each worker (it travels as it will for pmap: a named function resolves to the worker's own, a closure arrives as the master's code). A worker that cannot receive it records a failed observation instead of failing run!. DataVault floor 0.8.6. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
sotashimozono
marked this pull request as draft
September 22, 2026 11:40
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to QAtlasHub/DataVault.jl#56 (observation v2). Depends on DataVault 0.8.6 being registered in General. Until then CI cannot resolve it.
run!passeswork_fntoDataVault.observe_sources(...; code=[work_fn])on the master and on each worker. It travels the same way it will for pmap: a named function resolves to the worker's own, and a closure arrives as the master's code, which the observation names as "arrived from another process".work_fn, that is recorded as a failed observation (the worker's markers getobservation=unknownand anobserve_failedevent) rather than failingrun!.Tests (
test/run/test_run_observe.jl):obs2-;unverified, and the reason names it;unverified, "arrived from another process".Run locally against the DataVault branch: 18 checks pass.
🤖 Generated with Claude Code