Raise the stop flag after the first key, not after 50 ms (0.6.7) - #57
Merged
Merged
Conversation
The test assumed `run!` starts within 50 ms. With DataVault 0.8.7 a run-start observation keeps the packages the process loaded, which takes most of a second, so the timer fired before any key ran and `result.done >= 1` failed (0 >= 1), both on DataVault#58's downstream job and locally. The old test was run against 0.8.7 here and fails the same way; this one passes. The flag is still raised by a concurrent task, now once the first key has finished, so the test says the same thing without a clock. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
📚 Docs preview: https://qatlashub.github.io/SweepRunner.jl/previews/PR57/ (updates on each push to this PR) |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_run_adversarial.jl's "stop_flag raised mid-execution" test raised the flag from a 50 msTimer. That assumedrun!starts within 50 ms.With QAtlasHub/DataVault.jl#58 (0.8.7), the run-start observation also keeps every package the process loaded, so that a revision can be recomputed from itself. Startup then takes about 0.5–0.7 s (measured with 21 packages). The timer fires before any key runs, and
result.done >= 1fails with0 >= 1.That is the failure in #58's downstream
SweepRunnerjob. I reproduced it locally with the test frommainagainst DataVault 0.8.7.Change. A concurrent task still raises the flag, but now it waits until the first key has finished instead of waiting on a clock. The test checks the same thing and no longer depends on startup time. Locally, the whole file passes against DataVault 0.8.7 (6 testsets).
Test-only change. The version bump is for VersionCheck.
🤖 Generated with Claude Code