Repository navigation
Remove template files that read as configuration but never took effect - #62
Merged
Merged
Conversation
.github/rulesets/main-protection.json was never applied (the repo's protection is classic branch protection, set in its settings), and requires a check named `build` that this repo does not have, so applying it as written would make main unmergeable. .github/scripts/setup_project.jl is the generator template's module-renaming scaffold. Refs QAtlasHub/.github#25 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
📚 Docs preview: https://qatlashub.github.io/SweepRunner.jl/previews/PR62/ (updates on each push to this PR) |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs QAtlasHub/.github#25.
Removes: .github/rulesets/main-protection.json, .github/scripts/setup_project.jl
.github/rulesets/main-protection.jsonhas never been applied. This repo'smainis protected by classic branch protection in the repository settings, andgh api .../rulesetsreturns nothing. The file also requires a status check namedbuild, which this repo does not have, so applying it as written would makemainunmergeable. Anyone reading it gets the wrong answer to "how is this repo protected?"..github/scripts/setup_project.jlis the template's scaffold that renamesMyModule.Nothing else in the repo references these files (checked with
git grep). No code changes, so no version bump;version / check-versionwill be red, and it is not a required check here.🤖 Generated with Claude Code