refactor(ci): the timing-history read becomes the action #69 added - #70
Merged
Merged
Conversation
#69 restored the pre-#68 inline block to unbreak every consumer, and added `actions/read-history` in the same PR so that a workflow could name it — `uses: …@main` resolves against main, so the action had to be there first (measured: with both halves in one PR the run died at `Can't find 'action.yml' … @main` before any step executed). The action is on main now, so the duplicate goes. What is left is one copy of the read, in a file that `read-history.test.sh` runs unchanged, reachable from every caller because an action's own files are fetched with it. This repository cannot verify the consumer half of that — it is its own caller, which is the whole shape of #54 and #69 — so the check is deliberate rather than implied: a downstream PR (ParaLinearAlgebra.jl #426) is re-run against this immediately after the merge.
Contributor
|
📚 Docs preview: https://codes.sota-shimozono.com/TestShards.jl/previews/PR70/ (updates on each push to this PR) |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second half of #69, which could not be in it.
#69 had to do two things at once and could only merge one form of the step:
actions/read-history/was added, becauseuses: …@mainresolves against main and theaction has to be there before a workflow can name it. Measured, with both halves in one PR:
Can't find 'action.yml' … for action 'QAtlasHub/TestShards.jl/actions/read-history@main',before any step ran.
The action is on main now, so the duplicate goes. What is left is one copy of the read, in a
file
read-history.test.shruns unchanged, reachable from every caller because an action's ownfiles are fetched with it — into the runner's action directory, not into the consumer's workspace
(which is why this is an action and not a second
actions/checkoutof this repository: that wouldput
src/*.jlinside the consumer's coverage sweep).The verification this repository cannot do by itself
TestShards is its own caller, so a green run here does not exercise the consumer path — that is
the exact shape of #54 and of #69. So the check is deliberate: ParaLinearAlgebra.jl #426 is
re-run against this immediately after the merge, and its "Shard labels" job either finds the
action or does not.