Skip to content

The timing history stopped recording when prebuild was added #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sotashimozono merged 2 commits into from
Sep 6, 2026
Merged

The timing history stopped recording when prebuild was added #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c8de52
The timing history stopped recording when prebuild was added
sotashimozono Sep 6, 2026
e991438
Bump to 0.3.40
sotashimozono Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/sharded-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,7 +1169,14 @@ jobs:
timings:
name: Record timing history
needs: test
if: ${{ inputs.record-timings && (github.event_name == 'push' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch) && needs.test.result == 'success') }}
# `!cancelled()` is load-bearing, not decoration. `test` needs `prebuild`, which is skipped
# whenever the input is off — its default — and a job whose `if` carries no status-check
# function inherits that skip through the graph even though `test` itself ran and passed.
# Measured: on every consumer this job has been skipped since #36 introduced `prebuild`,
# while `needs.test.result` was `success` the whole time — `gate`, which checks exactly that
# and fails the run if it is not `success`, has been green on the same runs. The two
# siblings that survived, `collect` and `gate`, both carry `always()`; this one did not.
if: ${{ !cancelled() && inputs.record-timings && github.event_name == 'push' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch) && needs.test.result == 'success' }}
runs-on: ${{ fromJSON(inputs.helper-runner) }}
permissions:
contents: write # force-pushes the ci-timings orphan branch
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "TestShards"
uuid = "acceef1d-f5e0-4fe4-a546-818dc56ce7b2"
version = "0.3.39"
version = "0.3.40"
authors = ["sota shimozono <shimozono-sota631@g.ecc.u-tokyo.ac.jp>"]

[deps]
Expand Down
Loading