fix: the config decides where its results go - #6
Merged
Merged
Conversation
Every driver computed `OUTDIR` from the environment and handed it to `DataVault.Vault` as a keyword.
`Vault` already resolves that itself — keyword, then `DATAVAULT_OUTDIR`, then the config's `[study]
outdir` — and a keyword wins, so passing one made the config's own setting permanently unreachable.
The comment above the line said "outdir precedence (DataVault resolves it)" while the next line took
the decision away from it.
The drivers now pass `run=` only. Measured both directions, which is the point of the change:
DATAVAULT_OUTDIR unset -> out/data/example/phase1/ (the config's [study] outdir)
DATAVAULT_OUTDIR=/tmp/x -> /tmp/x/data/example/phase1/ (the environment overriding it)
Before, the second worked and the first could not: the documented order was "environment beats
config", the real order was "the script beats everything".
|
📚 Docs preview: https://qatlashub.github.io/templateHPC.jl/previews/PR6/ (updates on each push to this PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every driver did this:
Vaultalready resolvesoutdiritself:A keyword wins, so passing one made the config's own
[study] outdirpermanently unreachable.The comment above the line said "outdir precedence (DataVault resolves it): kwarg > ENV > config"
while the next line took the decision away from it. The documented order was "environment beats
config"; the real order was "the script beats everything".
Measured, both directions
The first of those could not happen before this change.
The drivers now pass
run=only, and say why in a comment where the temptation is.