Skip to content

添加boost#1

Merged
llLeo306 merged 1 commit intoQDU-Robomaster:devfrom
Rui-Xiaoyu:master
Feb 27, 2026
Merged

添加boost#1
llLeo306 merged 1 commit intoQDU-Robomaster:devfrom
Rui-Xiaoyu:master

Conversation

@Rui-Xiaoyu
Copy link
Copy Markdown
Contributor

@Rui-Xiaoyu Rui-Xiaoyu commented Feb 27, 2026

Summary by Sourcery

New Features:

  • Introduce a boost boolean field in the chassis control command to indicate power boost mode when Shift is pressed.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Feb 27, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a boost mode flag to the chassis control command structure to indicate when power boost (e.g., Shift key pressed) is active.

Class diagram for updated ChassisCMD structure with boost flag

classDiagram
    class CMD {
    }

    class ChassisCMD {
        float x
        float y
        float z
        bool boost
    }

    CMD "1" *-- "1" ChassisCMD
Loading

File-Level Changes

Change Details Files
Extend chassis control command structure to support a boost/power-enhance mode.
  • Align existing x, y, z float members for readability and consistency in comments.
  • Add a new bool boost field indicating power boost mode when the Shift key is pressed.
CMD.hpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since boost is added to ChassisCMD, ensure all construction/initialization sites are updated so boost is explicitly set to a known default value to avoid undefined behavior.
  • If ChassisCMD is serialized (e.g., sent over a bus or stored in binary), check that the added bool does not break the expected layout/size and update any serialization/deserialization logic accordingly.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since `boost` is added to `ChassisCMD`, ensure all construction/initialization sites are updated so `boost` is explicitly set to a known default value to avoid undefined behavior.
- If `ChassisCMD` is serialized (e.g., sent over a bus or stored in binary), check that the added `bool` does not break the expected layout/size and update any serialization/deserialization logic accordingly.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@llLeo306 llLeo306 merged commit b32ab18 into QDU-Robomaster:dev Feb 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants