添加boost#1
Merged
llLeo306 merged 1 commit intoQDU-Robomaster:devfrom Feb 27, 2026
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a boost mode flag to the chassis control command structure to indicate when power boost (e.g., Shift key pressed) is active. Class diagram for updated ChassisCMD structure with boost flagclassDiagram
class CMD {
}
class ChassisCMD {
float x
float y
float z
bool boost
}
CMD "1" *-- "1" ChassisCMD
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since
boostis added toChassisCMD, ensure all construction/initialization sites are updated soboostis explicitly set to a known default value to avoid undefined behavior. - If
ChassisCMDis serialized (e.g., sent over a bus or stored in binary), check that the addedbooldoes not break the expected layout/size and update any serialization/deserialization logic accordingly.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since `boost` is added to `ChassisCMD`, ensure all construction/initialization sites are updated so `boost` is explicitly set to a known default value to avoid undefined behavior.
- If `ChassisCMD` is serialized (e.g., sent over a bus or stored in binary), check that the added `bool` does not break the expected layout/size and update any serialization/deserialization logic accordingly.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
New Features: