Skip to content

Refac laser beam#27

Open
szabo137 wants to merge 5 commits into
QEDjl-project:mainfrom
szabo137:refac-laser-beam
Open

Refac laser beam#27
szabo137 wants to merge 5 commits into
QEDjl-project:mainfrom
szabo137:refac-laser-beam

Conversation

@szabo137
Copy link
Copy Markdown
Member

In this PR, the laser beam type is refactored to model more realistically.

TODO

  • simplify structure
  • add tests for upstream structures
  • add docs
    • doc strings
    • tutorials for implementing the interfaces

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.00000% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@bd88577). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/beams/laser/parameter.jl 97.77% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage        ?   59.25%           
=======================================
  Files           ?        6           
  Lines           ?      162           
  Branches        ?        0           
=======================================
  Hits            ?       96           
  Misses          ?       66           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants