Add rejection sampler#70
Conversation
ff14750 to
8e91f1d
Compare
|
Currently, test fail due to RejectionSamplers not being registered. |
|
This should (hopefully) get fixed once QEDjl-project/QEDprocesses.jl#141 is merged |
) See QEDjl-project/QEDbase.jl#176 This is useful for a fix to the problem in QEDjl-project/QEDevents.jl#70
|
I tested it locally before, it really should be working now. Maybe a push is necessary to update the CI? |
Oh, it's not working because QEDprocesses is only a dependency in extras, so the CI doesn't load the dev version, only the released version of it, which doesn't have the fix |
Indeed, it is still not working. And the error message is weird because it refers to |
Yeah, as I said, it's not using the dev version because QEDprocesses is not a "real" dependency, only an [extra] dependency. |
|
I wanted to release patch versions for base and processes anyway, which should fix this. Also I believe we decided that processes is going to become a real dependency at some point, so you could just add it here too. |
Understood (I missed your previous answer for some reason 🤷♂️). So it should work if we release QEDprocesses (and QEDbase)? I try to think about a simple way to add the extensions manually, without digging too deep into IntegrationTests.jl (again, sorry @SimeonEhrig 😅) |
e793594 to
4ade8bd
Compare
4ade8bd to
1d13215
Compare
Uh oh!
There was an error while loading. Please reload this page.