Add transform based sampler#40
Open
szabo137 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an abstract sampler that operates by transforming random numbers into the sample space.
In this PR, this is based on two interface functions transforming values and weights
Where
random_numberis a number, but also anSVectororNTuple.To implement this in place, this PR introduces
_transform!(sampler, buffer, random_number_vector)where
bufferis aSampleBuffer.The Interface is tested using a mock sampler
MockTransformbasedSampler, which transforms every random number into a sample filled with a given number and the weight of one.