Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking Return in Overview can terminate QIDIStudio on Linux with an X11/GLX
BadMatcherror and exit code 1.The Return handler calls
reload_scene()on the Prepare canvas while Overview is still rendering. This rebinds the shared OpenGL context before Overview finishes drawing and callsSwapBuffers().Fix
Defer the Return action using the existing end-of-frame callback mechanism, so Overview finishes rendering and swapping buffers before the Prepare canvas is reloaded.
The existing view-change event, gizmo resets, explosion-ratio reset, and usage tracking are preserved.