Optimize trace_product for non-translationally symmetric operators#218
Closed
swiatlowemnie333 wants to merge 1 commit into
Closed
Optimize trace_product for non-translationally symmetric operators#218swiatlowemnie333 wants to merge 1 commit into
swiatlowemnie333 wants to merge 1 commit into
Conversation
Collaborator
|
Hi @swiatlowemnie333, I believe you've submitted your PR to the wrong repository, so I'm closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an analytical short-circuit path in
trace_productfor operators whose core consists of 2 or 3 mutually anticommuting Pauli strings.Instead of scaling exponentially with full matrix powers via squaring, the trace is evaluated directly using the coefficient norms. Translationally symmetric operators (
Operator{<:PauliStringTS}) are explicitly bypassed to preserve standard spatial shift logic.All local test suites pass successfully. Fixes the performance bottleneck for these specific structures.