Conversation
Finemas
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes logging execution from a global behavior in LoggerManager to a per-logger behavior.
LoggerManager now sends synchronous loggers immediately on the caller thread and dispatches only asynchronous loggers onto its serial background queue. FileLogger is configured as asynchronous, while the rest
of the built-in loggers remain synchronous by default. This makes console/native logs visible immediately during debugging or before crashes, without forcing file writes onto the caller thread.
What changed
Why
Previously, all loggers were funneled through the same async queue, which delayed console output. That made debugging worse because logs could be missing when hitting breakpoints or when the app crashed. With
this change, console-oriented loggers can remain synchronous, while heavier loggers like FileLogger can still run asynchronously.