Skip to content

3.x.x: correct the 3.1.1 notes, the release steps and two runbooks before v3.1.1 is tagged (#813, #814) - #819

Merged
kiwidream merged 1 commit into
3.x.xfrom
orca/813-3.1.1-notes-and-runbooks
Oct 29, 2026
Merged

kiwidream merged 1 commit into
3.x.xfrom
orca/813-3.1.1-notes-and-runbooks

Conversation

@kiwidream

@kiwidream kiwidream commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

These are the documentation fixes from the review of #811 (v3.1.1) that should ship in 3.1.1. The tag freezes the notes, and operators follow the tagged runbooks.

3.1.1 notes (#813 items 1, 3, 4, 5)

Release guide (#813 item 6)

docs/releasing.md now rewrites the notes' inline relative links to blob/v<version>/ for the GitHub release body, as was done by hand for 3.1.0. I tested the sed on the 3.1.1 notes: it rewrites all 17 relative links and leaves anchors alone.

Runbooks (#814 items 3a and 3b, with item 4's guidance)

Not in this PR

Checks

  • tests/test_docs_lab_prism_references.py: 147 tests OK.
  • scripts/check_prism_settings.py: passes.
  • Two local /code-review medium passes; all their findings are addressed.

Part of #813 and #814.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

#814)

- 3.1.1 notes: the L3 runs the tag can promote, and the first l3-full runs
  on a tree with #788 (#810, #811), in Verification and #779; a 3.1.0
  frontend's peer sync still lacks #799's blob-GC fence on its node's
  database; "no released migration's SQL changed" instead of sqlx
  checksums the native runner doesn't keep; CI on the promoted main commit
  rather than a tag dispatch.
- docs/releasing.md: rewrite the notes' relative links for the release
  body.
- prism-rust-migration.md, prism-ledger-ops.md: from 3.1.1 the #709 and
  #731 sidecar procedures aren't needed, and the #731 checker's re-check
  exits 3 for rows 3.1.1 imports; 032 in the migration transaction.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T16:03:25.985749Z 238fcef PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@qbit-reviewer qbit-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 finding posted inline.

Comment thread docs/releasing.md
git show v<version>:doc/release-notes-<version>.md > /tmp/qbit-release-notes.md
git show v<version>:doc/release-notes-<version>.md | sed -E \
-e 's#\]\(\.\./#](https://github.com/Qbit-Org/qbit-mining-bootstrap/blob/v<version>/#g' \
-e 's#\]\(([^)#/:][^):]*)\)#](https://github.com/Qbit-Org/qbit-mining-bootstrap/blob/v<version>/doc/\1)#g' \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1. [medium] The release-notes sed uses '#' as its s delimiter but also puts '#' in [^)#/:], so GNU sed rejects the command

docs/releasing.md:78

docs/releasing.md:78 runs s#\]\(([^)#/:][^):]*)\)#...#g. GNU sed finds the end of an s command's regex by scanning for the delimiter character and skips only backslash escapes; it does not handle bracket expressions. The regex therefore ends at the # inside [^)#, the text /:][^):]*)\) becomes the replacement, and ]​(https:... is read as flags. The result is a compile error ("unknown option to s'"). BSD/macOS sed handles bracket expressions here, which may be why the author's test passed. On Linux, sed exits before writing anything. The shell has already created and truncated /tmp/qbit-release-notes.md by then (line 79), and the documented block goes straight on to gh release create ... --notes-file /tmp/qbit-release-notes.md(lines 80-81). That publishes the v<​version> GitHub release with empty notes, and publishing can't be cleanly undone. Escaping the bracket's hash as[^)#/:]or switching to a delimiter such as|` makes the command work in both seds.

@kiwidream
kiwidream merged commit fc5bdbc into 3.x.x Oct 29, 2026
41 checks passed
kiwidream added a commit that referenced this pull request Oct 29, 2026
…'s fixes

Merge 3.x.x at 987027f into the promotion branch: #818 (verify-ca trusts
only sslrootcert), #819 (3.1.1 notes, release steps and runbooks), #820
(an idle frontend's landing waits retire at maturity) and #821 (the
pre-migrate lowers its own deadlock_timeout for a blocking autovacuum
pass), from the review of this promotion.

The promotion's edits: the release date (2026-10-29), the fix PRs' numbers
in the 3.1.1 notes, and the 3.1.1 record in docs/releasing.md with the new
cutoff.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant