Skip to content

fix: keep session open across multiple deletions - #20

Open
sudo-rm-rf-star wants to merge 1 commit into
developfrom
fix/keep-session-open-across-deletions
Open

fix: keep session open across multiple deletions#20
sudo-rm-rf-star wants to merge 1 commit into
developfrom
fix/keep-session-open-across-deletions

Conversation

@sudo-rm-rf-star

@sudo-rm-rf-star sudo-rm-rf-star commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fixes "Your version is not your last personal version" error when running Delete Product multiple times
  • Root cause: handle_delete_product was starting and ending a session per invocation. End-session signals all modifications are complete and triggers server-side processing (unpack). Starting a new session immediately after causes a version conflict because the unpack is still in progress
  • Fix: keep one session open and let the user delete multiple products within it, only ending the session when done

Test plan

  • Run sample, pick "Delete Product", delete multiple walls in a row — should succeed without errors

@sudo-rm-rf-star
fix: keep session open across multiple deletions
3cfa39b 
The sample was starting and ending a session for each delete operation.
End-session signals all modifications are complete and triggers
server-side processing (unpack), so starting a new session immediately
after causes a version conflict.

Keep one session open for all deletions and only end it when the user
is done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sudo-rm-rf-star