-
Notifications
You must be signed in to change notification settings - Fork 27
chore(service): allow to retrieve envoy gateway logs #2326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(service): allow to retrieve envoy gateway logs #2326
Conversation
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
|
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 |
|
A preview environment was automatically created via Qovery. Another comment will be posted when deployments are finished |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #2326 +/- ##
===========================================
+ Coverage 47.53% 48.97% +1.43%
===========================================
Files 1279 929 -350
Lines 23524 18745 -4779
Branches 6931 5563 -1368
===========================================
- Hits 11182 9180 -2002
+ Misses 10191 7824 -2367
+ Partials 2151 1741 -410
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Your preview environment has been successfully deployed ! |
dcafb9a to
ab4a64d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR extends the service logs functionality to support retrieving Envoy Gateway logs, mirroring the existing capability for Nginx logs. Users can now filter and view logs from both Nginx and Envoy ingress controllers alongside their service logs.
Changes:
- Added 'envoy' filter support throughout the logs architecture (search, context, data access)
- Implemented Envoy-specific WebSocket subscriptions and query handling for both live and historical logs
- Added UI elements (ENVOY badge) to distinguish Envoy logs from regular service and Nginx logs
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| search-service-logs.tsx | Added 'envoy' to valid filter keys, buildValueOptions, buildQueryParams, and filter options |
| search-service-logs.spec.tsx | Updated test to use refetchHistoryLogs parameter instead of isLoading |
| search-service-logs-helpers.spec.ts | New test file for filter parsing logic (tests inline logic, not implementation) |
| service-logs-context.tsx | Added envoy BooleanParam to query parameters |
| row-service-logs.tsx | Added isEnvoy detection, ENVOY badge, and conditional rendering logic matching nginx |
| row-service-logs.spec.tsx | Added comprehensive test coverage for envoy logs behavior |
| use-service-live-logs.ts | Added envoy WebSocket subscription with separate query and log handler |
| use-service-history-logs.ts | Added envoy query support, log accumulation, and refetch logic |
| domains-service-logs-data-access.ts | Added LogType type ('service' | 'nginx' | 'envoy'), updated buildLokiQuery to support envoy |
| domains-service-logs-data-access.spec.ts | New comprehensive test file for buildLokiQuery with all log types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...domains/service-logs/feature/src/lib/search-service-logs/search-service-logs-helpers.spec.ts
Show resolved
Hide resolved
libs/domains/service-logs/feature/src/lib/hooks/use-service-live-logs/use-service-live-logs.ts
Outdated
Show resolved
Hide resolved
libs/domains/service-logs/feature/src/lib/hooks/use-service-live-logs/use-service-live-logs.ts
Outdated
Show resolved
Hide resolved
libs/domains/service-logs/feature/src/lib/hooks/use-service-live-logs/use-service-live-logs.ts
Outdated
Show resolved
Hide resolved
...domains/service-logs/feature/src/lib/search-service-logs/search-service-logs-helpers.spec.ts
Outdated
Show resolved
Hide resolved
...domains/service-logs/feature/src/lib/search-service-logs/search-service-logs-helpers.spec.ts
Outdated
Show resolved
Hide resolved
ab4a64d to
c18bed0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
libs/domains/service-logs/data-access/src/lib/domains-service-logs-data-access.ts
Outdated
Show resolved
Hide resolved
libs/domains/service-logs/data-access/src/lib/domains-service-logs-data-access.ts
Outdated
Show resolved
Hide resolved
...ains/service-logs/feature/src/lib/hooks/use-service-history-logs/use-service-history-logs.ts
Outdated
Show resolved
Hide resolved
...ains/service-logs/feature/src/lib/hooks/use-service-history-logs/use-service-history-logs.ts
Outdated
Show resolved
Hide resolved
Ticket: QOV-1430
c18bed0 to
4d264f4
Compare
rmnbrd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done Ben! Approved 💯 👏
|
🎉 This PR is included in version 1.273.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Issue: Ticket: QOV-1430
This PR allows users to retrieve Envoy logs for their services as they can already do for Nginx.
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release