Skip to content

Conversation

@benjaminch
Copy link
Collaborator

Summary

Issue: Ticket: QOV-1430

This PR allows users to retrieve Envoy logs for their services as they can already do for Nginx.

Screenshots / Recordings

image image

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@benjaminch benjaminch added the enhancement New feature or request label Jan 23, 2026
@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Truth can only be found in one place: the code

@benjaminch
Copy link
Collaborator Author

/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425

@RemiBonnet
Copy link
Member

Qovery Preview

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - chore(service): allow to retrieve envoy gateway logs - 2026-01-23T16:12:30Z

Another comment will be posted when deployments are finished

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 63.04348% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.97%. Comparing base (c81f0a5) to head (4d264f4).
⚠️ Report is 3 commits behind head on staging.

Files with missing lines Patch % Lines
...e-service-history-logs/use-service-history-logs.ts 38.88% 8 Missing and 3 partials ⚠️
...oks/use-service-live-logs/use-service-live-logs.ts 62.50% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2326      +/-   ##
===========================================
+ Coverage    47.53%   48.97%   +1.43%     
===========================================
  Files         1279      929     -350     
  Lines        23524    18745    -4779     
  Branches      6931     5563    -1368     
===========================================
- Hits         11182     9180    -2002     
+ Misses       10191     7824    -2367     
+ Partials      2151     1741     -410     
Flag Coverage Δ
unittests 48.97% <63.04%> (+1.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet
Copy link
Member

Qovery Preview

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console

@benjaminch benjaminch force-pushed the chore/QOV-1430/allow-to-retrieve-envoy-gateway-logs branch from dcafb9a to ab4a64d Compare January 23, 2026 17:49
@benjaminch benjaminch requested a review from Copilot January 23, 2026 17:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the service logs functionality to support retrieving Envoy Gateway logs, mirroring the existing capability for Nginx logs. Users can now filter and view logs from both Nginx and Envoy ingress controllers alongside their service logs.

Changes:

  • Added 'envoy' filter support throughout the logs architecture (search, context, data access)
  • Implemented Envoy-specific WebSocket subscriptions and query handling for both live and historical logs
  • Added UI elements (ENVOY badge) to distinguish Envoy logs from regular service and Nginx logs

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
search-service-logs.tsx Added 'envoy' to valid filter keys, buildValueOptions, buildQueryParams, and filter options
search-service-logs.spec.tsx Updated test to use refetchHistoryLogs parameter instead of isLoading
search-service-logs-helpers.spec.ts New test file for filter parsing logic (tests inline logic, not implementation)
service-logs-context.tsx Added envoy BooleanParam to query parameters
row-service-logs.tsx Added isEnvoy detection, ENVOY badge, and conditional rendering logic matching nginx
row-service-logs.spec.tsx Added comprehensive test coverage for envoy logs behavior
use-service-live-logs.ts Added envoy WebSocket subscription with separate query and log handler
use-service-history-logs.ts Added envoy query support, log accumulation, and refetch logic
domains-service-logs-data-access.ts Added LogType type ('service' | 'nginx' | 'envoy'), updated buildLokiQuery to support envoy
domains-service-logs-data-access.spec.ts New comprehensive test file for buildLokiQuery with all log types

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@benjaminch benjaminch force-pushed the chore/QOV-1430/allow-to-retrieve-envoy-gateway-logs branch from ab4a64d to c18bed0 Compare January 27, 2026 09:21
@benjaminch benjaminch requested a review from Copilot January 27, 2026 09:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@benjaminch benjaminch force-pushed the chore/QOV-1430/allow-to-retrieve-envoy-gateway-logs branch from c18bed0 to 4d264f4 Compare January 27, 2026 15:13
Copy link
Contributor

@rmnbrd rmnbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done Ben! Approved 💯 👏

@benjaminch benjaminch merged commit 79d35bb into staging Jan 27, 2026
10 checks passed
@benjaminch benjaminch deleted the chore/QOV-1430/allow-to-retrieve-envoy-gateway-logs branch January 27, 2026 15:44
@RemiBonnet
Copy link
Member

🎉 This PR is included in version 1.273.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants