Skip to content

Conversation

@fabienfleureau
Copy link
Collaborator

@fabienfleureau fabienfleureau commented Jan 26, 2026

Summary

Issue: QOV-1504 QOV-1499

Adds a git webhook status badge to service settings pages, showing whether auto-deploy webhooks are properly configured.
Adds a button to set the webhook on git provider (visible only when needed)

Changes

  • New GitWebhookStatusBadge component with states: Active, Not Configured, Misconfigured, Unable to Verify
  • New useGitWebhookStatus hook wrapping the API call
  • Badge displayed in settings for: Application, Job (git source), Terraform, Helm (git source)
  • Added tests for component and hook (10 tests)

Screenshots / Recordings

image image image image

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

You are going to thank you later if it contains tests

@fabienfleureau fabienfleureau force-pushed the feat/QOV-1504-git-webhook-status-badge branch 2 times, most recently from 554108f to 9686983 Compare January 26, 2026 13:45
@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 76.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.78%. Comparing base (c81f0a5) to head (86f3384).
⚠️ Report is 4 commits behind head on staging.

Files with missing lines Patch % Lines
...hooks/use-sync-git-webhook/use-sync-git-webhook.ts 0.00% 5 Missing ⚠️
...ui/page-settings-general/page-settings-general.tsx 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2331      +/-   ##
===========================================
+ Coverage    47.53%   47.78%   +0.25%     
===========================================
  Files         1279     1267      -12     
  Lines        23524    23070     -454     
  Branches      6931     6781     -150     
===========================================
- Hits         11182    11025     -157     
+ Misses       10191     9945     -246     
+ Partials      2151     2100      -51     
Flag Coverage Δ
unittests 47.78% <76.66%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabienfleureau fabienfleureau force-pushed the feat/QOV-1504-git-webhook-status-badge branch 2 times, most recently from 17ff31c to 04f9dab Compare January 27, 2026 13:48
@fabienfleureau fabienfleureau marked this pull request as ready for review January 27, 2026 13:49
@fabienfleureau fabienfleureau force-pushed the feat/QOV-1504-git-webhook-status-badge branch from 04f9dab to 4ee954d Compare January 27, 2026 13:51
@fabienfleureau fabienfleureau force-pushed the feat/QOV-1504-git-webhook-status-badge branch from 4ee954d to 6b504a2 Compare January 27, 2026 14:28
}),
})

export type { GitWebhookStatusResponse }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabienfleureau Get rid of this export please 🙏

@@ -0,0 +1 @@
export * from './auto-deploy-section'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you get rid of this file?

</Section>
</>
))
.with({ serviceType: 'CONTAINER' }, () => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.with({ serviceType: 'CONTAINER' }, (container) => (

<Heading>Deploy</Heading>
<EntrypointCmdInputs />
<AutoDeploySetting source="CONTAINER_REGISTRY" />
<AutoDeploySection serviceId={service.id} source="CONTAINER_REGISTRY" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<AutoDeploySection serviceId={service.id} source="CONTAINER_REGISTRY" />
<AutoDeploySection serviceId={container.id} source="CONTAINER_REGISTRY" />

@fabienfleureau fabienfleureau requested a review from rmnbrd January 27, 2026 15:55
@fabienfleureau fabienfleureau merged commit 1793274 into staging Jan 27, 2026
10 checks passed
@fabienfleureau fabienfleureau deleted the feat/QOV-1504-git-webhook-status-badge branch January 27, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants